104294 - Selection doesn't show for the end of lines but changes are applied to it

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[TucsonTester2]

Build ID: 20011009

Composer does not show that the end of a line is selected, but changes made to
that line (i.e. paragraph style) are applied.

Reproducible: Always

Steps to Reproduce:
1.Open Composer
2.Type in 3 lines of text
3.Highlight the bottom two lines starting from te bottom. Bring the pointer to
the end of the first line.  Make sure nothing is showing for a selection at the
end of the first line, then release the button.
4.From the paragraph style drop-down menu choose Heading 1

Actual Results:
Every line of text changes to Heading 1.

Expected Results:
I would expect that only the bottom two lines would change to Heading 1 since
there is nothing selected on the first line.

Comment 1

[Syd Logan]

Selection bug, don't know if it is a mountain or a mole hill. Over to mjudge.

Comment 2

[Alex Vincent [:WeirdAl]]

confirm Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.5+) Gecko/20011113

I'm of some doubt as to how much of a bug this is as well.  When you move the
mouse to select only to the beginning of the second line, the first line is not
affected.  By moving to the end of the first line, presumably, the first line is
affected as well.

I think we're accidentally selecting the <br /> element of the first line as
well, though it's invisible.  I really don't know if we can call that a bug or
not; it should be fairly obvious to the user that it's there.

Comment 3

[selmer (gone)]

Alex, I disagree.  Instead of using the pull-down to change the format, use the
B or one of the other controls to change the style.  Notice that the behaviors
are different even with the identical selection.

Comment 4

[mjudge]

I may have to relook at selection type bugs for caret placement and snapping of 
lines.  When I do these types of bugs will be addressed

Comment 5

[TucsonTester1]

Regarding Comment 2 . I don't think this is an actual 'bug' per se, but more in
the way that html tags are being used. When I tested this on Mac OSX built
2001121004, I did so two different ways. 

1) Open Navigator
2)Open Composer
3) Type 3 CONTINUOS lines of text in a paragraph form. (*Not hitting Enter at
the end of each line*)
4)Highlight the bottom line, and the majority of the middle line.
5)Choose Heading 1 from the Text Formating dropdown on the menu bar.

Note : All the text is selected as Heading 1 now.

Test #2.
1)Open New Composer Page.
2)Type 3 lines of text, however this time, use a <br> or hard return at the end
of each line so the lines are not continuos.
3)Highlight the bottom line, and the majority of the middle line.
4)Choose Heading 1 from the Text Formating Dropdown on the menu bar.

Note : Only the lines of text that have been highlighted changes to heading 1.

What appears to be happening here (since nobody here mentioned it yet) is the
<H1> tag is being placed at the begining of the text, as I expected it to do.
When you don't use the <br> at the end of each line, the tags are being placed
at the very begining. When using the <br> the <H1> tag is being placed at the
end of the last tag used (in this case, the <br> on the line above).

Comment 6

[Syd Logan]

Easily recovered from -- just select that line and reset the paragraph style.
Not to mention bold, italic, underline, colors work fine, and our estimation is
these are going to be changed in this scenario far more often than the paragraph
style. 

Comment 7

[mjudge]

yes i was correct this bug has been fixed.  please verify since i cannot point
to the exact code any more. marking fixed

Comment 8

[rubydoo123]

tested using the trunk build from 2003040308 on win2K

yes, indeed this is fixed, this is what I did:
1. entered 3 lines, at the end of each line I hit enter
2. did a drag/select from the end of the third line to the end of the first
line, selected H1 and onlyt the 2nd and 3rd lines changed.
3. selected undo until I was back to the 3 lines of text, selecetd from the end
of the 1st line to the end of the 3rd line and selected H1, and only the 2nd and
3rd lines changed.