Launcher icon for search activity

VERIFIED FIXED in Firefox 34

Status

()

Firefox for Android
Search Activity
P1
normal
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: Margaret, Assigned: eedens)

Tracking

Trunk
Firefox 34
All
Android
Points:
---

Firefox Tracking Flags

(firefox34 verified)

Details

Attachments

(4 attachments, 6 obsolete attachments)

(Reporter)

Description

3 years ago
ibarlow or antlam, can you give us an icon to use for the launcher screen?

Then eedens can put it into a patch :)
Flags: needinfo?(ibarlow)
Flags: needinfo?(alam)
Sure, do you guys know what the dimensions are for this? 

Also, are we talking about the icon in the apps drawer or the icon (currently a white magnifying glass) you see when you swipe up? Are these the same as the one in the context menu that pops up when you land on the magnifying glass as well?
Flags: needinfo?(alam)
(Reporter)

Updated

3 years ago
Priority: -- → P1
(Assignee)

Comment 2

3 years ago
Anthony --

We have the ability to set two icons for the search activity; here's where they would show up:

Icon 1) App drawer / context menu / home screen  (normal android icon)
Icon 2) Replacement for slide-up magnifying glass (replacement happens only if we're the default handler for slide up)

In terms of sizing, Icon 1 is the normal Android launcher icon (48px square in MDPI). For Icon 2, the sizing is not documented. However, here is a link to the icons that are used natively (they are 108px in MDPI):

Activated: https://github.com/vokalinteractive/android_frameworks_base/blob/master/tests/Assistant/res/drawable-mdpi/ic_action_assist_activated.png
Normal: https://github.com/vokalinteractive/android_frameworks_base/blob/master/tests/Assistant/res/drawable-mdpi/ic_action_assist_normal.png

------

For reference, here's how each icon is set in AndroidManifest:

Icon 1)  Use  `android:icon` as an attribute of the SA's activity element.
Icon 2)  Add a `meta-data` element to the SA's activity element:

           <meta-data
                android:name="com.android.systemui.action_assist_icon"
                android:resource="@drawable/ic_sa_launcher" />

The Icon 2 drawable supports selectors, eg: http://androidxref.com/4.4.4_r1/xref/frameworks/base/tests/Assistant/res/drawable/ic_action_assist.xml
Flags: needinfo?(alam)
(Assignee)

Comment 3

3 years ago
Created attachment 8461779 [details] [diff] [review]
bug-1042958-wip.patch

Posting a patch with the relevant config changes. It uses placholder images; once antlam gets those posted, I can swap them in and make a fresh patch.
Attachment #8461779 - Flags: review?(margaret.leibovic)
(Reporter)

Comment 4

3 years ago
Comment on attachment 8461779 [details] [diff] [review]
bug-1042958-wip.patch

Review of attachment 8461779 [details] [diff] [review]:
-----------------------------------------------------------------

f+ for now, holding off on r+ until we get the real icons. But this looks pretty simple :)

::: mobile/android/search/res/drawable/search_swipe_launcher_selector.xml
@@ +20,5 @@
> +    <item
> +        android:state_enabled="true"
> +        android:state_active="false"
> +        android:state_focused="true"
> +        android:drawable="@drawable/search_swipe_launcher_activated" />

Do you need both of these items? Would it work to just replace the bottom two items with:

<item
    android:state_enabled="true"
    android:drawable="@drawable/search_swipe_launcher_activated" />
Attachment #8461779 - Flags: review?(margaret.leibovic) → feedback+
Created attachment 8465641 [details]
prev_icon_explore.png

Here are some explorations we went through but most of it seemed to be too forced, at least for the time being. 

I think the best choice right now would be to keep it basic to both match the current stage of this "product" and to keep it open.

For this launcher icon's first iteration I've tried to bring over traits of our build icons like the shape, shadow and lighting to help it feel somewhat like "Firefox". To be more reusable, I wanted to focus on the icon and basic shapes so that we could both be direct about what this icon does and to leave our options open.
Flags: needinfo?(alam)
Created attachment 8465643 [details]
SA_launchericon.zip

Attaching icon files
(Assignee)

Comment 7

3 years ago
(In reply to Anthony Lam (:antlam) from comment #6)
> Created attachment 8465643 [details]
> SA_launchericon.zip
> 
> Attaching icon files

Anthony, here's a build with your icons. OK to land? http://goo.gl/a5YcdB
Flags: needinfo?(alam)
hm. edges seem to be too straight. 

Let me attach some new icons.
Flags: needinfo?(alam)
Created attachment 8465677 [details]
SA_launchericon.zip

try these :)
Attachment #8465643 - Attachment is obsolete: true
(Assignee)

Comment 10

3 years ago
(In reply to Anthony Lam (:antlam) from comment #9)
> Created attachment 8465677 [details]
> SA_launchericon.zip
> 
> try these :)

These have similar edge artifacts. See goo.gl/2GdE3v.

Also, I noticed these are scaled below 48px; MDPI is 44px, for example. If you'd like the icon smaller, I'd recommend rendering to 44px, and then adding 2px of transparent border.
Flags: needinfo?(alam)
Anthony - You have to use the exact sizes Android expects. It will upscale/downscale otherwise.
(Assignee)

Comment 12

3 years ago
Anthony - If it helps to debug the edge artifacts, here are Chrome's icons, which are circular as well: https://drive.google.com/folderview?id=0B370567wSAPBR18wYVpycVF3eGM&usp=sharing
Created attachment 8465756 [details]
SA_launchericon.zip

My bad guys - in my haste I selected the image rather than the art board to export.

Try these...? :)
Attachment #8465677 - Attachment is obsolete: true
Flags: needinfo?(alam)
Created attachment 8465801 [details]
SA_launchericon.zip

saw some weird artifacts.. let's give these a go in an attempt at anti aliasing..
Attachment #8465756 - Attachment is obsolete: true
(Assignee)

Comment 15

3 years ago
(In reply to Anthony Lam (:antlam) from comment #14)
> Created attachment 8465801 [details]
> SA_launchericon.zip
> 
> saw some weird artifacts.. let's give these a go in an attempt at anti
> aliasing..

Here's what it looks like: https://imgur.com/ankKHvh
Created attachment 8465819 [details]
SA_launchericon.zip

another attempt. It seems to work in the Android Asset Studio and on a black background in Sketch.
Attachment #8465801 - Attachment is obsolete: true
(Assignee)

Comment 17

3 years ago
(In reply to Anthony Lam (:antlam) from comment #16)
> Created attachment 8465819 [details]
> SA_launchericon.zip
> 
> another attempt. It seems to work in the Android Asset Studio and on a black
> background in Sketch.

https://imgur.com/8O7HLb5

Updated

3 years ago
Flags: needinfo?(ibarlow)
(Assignee)

Comment 18

3 years ago
Created attachment 8466276 [details]
blur_mask.png

Anthony, I pulled back opacity to 90% for 1dp around your assets. Are you ok with this for enabling in nightly? We can always swap out with something later.
Flags: needinfo?(alam)
Hold off for a bit Eric, I'm going to take a look with Anthony at what's going on here today and we'll get you some finalized assets.
Created attachment 8466372 [details]
SA_launchericon.zip

Try these..
Attachment #8465819 - Attachment is obsolete: true
Flags: needinfo?(alam)
(Assignee)

Comment 21

3 years ago
Created attachment 8466391 [details] [diff] [review]
bug-1042958.patch
Attachment #8461779 - Attachment is obsolete: true
Attachment #8466391 - Flags: review?(margaret.leibovic)
(Reporter)

Comment 22

3 years ago
Comment on attachment 8466391 [details] [diff] [review]
bug-1042958.patch

\o/
Attachment #8466391 - Flags: review?(margaret.leibovic) → review+
(Reporter)

Comment 23

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/5f74b4ec580f
(Assignee)

Comment 24

3 years ago
https://github.com/ericedens/FirefoxSearch/commit/15a62a60aab4f66636d860eb8cafaa67deccb3a7
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/5f74b4ec580f
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34

Comment 26

3 years ago
Verified as fixed in build 34.0a1 (2014-08-07);
Device: Samsung Galaxy Nexus (Android 4.2.1).
Status: RESOLVED → VERIFIED
status-firefox34: --- → verified
You need to log in before you can comment on or make changes to this bug.