1042967 - |cfx testpkgs -f anything| loads all test-xx modules

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Tomislav Jovanovic :zombie]

whatever i put after -f, it seems to load all test modules, even if it runs tests only from those that satisfy the regex pattern.

this is a problem because in e10s mode, just loading some test-modules throws, and nothing gets tested..

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1562

Comment 2

[Tomislav Jovanovic :zombie]

Comment on attachment 8461184 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1562

r+, though i would like if you could either answer or address a question i have in the PR comments..

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/a0aab58a8acf411f87ad671a3af324f810974ac2
Bug 1042967 filter filenames before loading the file

https://github.com/mozilla/addon-sdk/commit/4b3868f7f03650388e162970438a7261591531c3
Merge pull request #1562 from erikvold/1042967

Bug 1042967 filter filenames before loading the file r=@zombie

Comment 4

[Tomislav Jovanovic :zombie]

this got reverted: 

https://github.com/mozilla/addon-sdk/commit/74687d165b15de5d044ef0ad8e056ea56d8e0250#diff-d41d8cd98f00b204e9800998ecf8427e

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/52fcc099977098e7a43de966f2e35161860cfce4
Bug 1042967 filter filenames before loading the file