[Notes] Add Bengali (bn-BD) Translation to Notes App

RESOLVED FIXED in Firefox OS v2.1

Status

Firefox OS
Gaia::Notes
P2
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: doliver, Assigned: doliver)

Tracking

unspecified
2.1 S3 (29aug)
x86_64
Gonk (Firefox OS)

Firefox Tracking Flags

(b2g-v2.1 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
+++ This bug was initially created as a clone of Bug #943099 +++
(Assignee)

Comment 1

4 years ago
Created attachment 8461139 [details]
notes.bn-BD.properties

This translation was provided by m@github (originally as https://github.com/mozilla-b2g/notes/pull/41/).

Will upload these values to the Transifex project and then re-export into the Notes repo.
(Assignee)

Comment 2

4 years ago
Oops, credit goes to maktrix @ github.

Comment 3

4 years ago
(In reply to Dylan Oliver [:doliver] from comment #1)
> Created attachment 8461139 [details]
> notes.bn-BD.properties
> 
> This translation was provided by m@github (originally as
> https://github.com/mozilla-b2g/notes/pull/41/).
> 
> Will upload these values to the Transifex project and then re-export into
> the Notes repo.

Sorry my mistake, in a hurry I edited the en-US file instead of created a new one for bn-BD. Thank you for being careful and not merging right away. 

I have transifex account https://www.transifex.com/accounts/profile/maktrix/ let me know the URL for me to upgrade translations, just in case if there is any spelling mistake or I could do better if truncated.
(Assignee)

Comment 4

4 years ago
The Transifex project is here: https://www.transifex.com/projects/p/notes/

I have uploaded your strings from the pull request so you might want to check them for correctness just to ensure that I got everything right in the conversion process. There are also two more strings that we need for the manifest file and then I think we'll be all set.
Assignee: nobody → doliver
Flags: needinfo?(mahayalamkhan)
(Assignee)

Comment 5

4 years ago
Created attachment 8462877 [details] [review]
PR - add bn-BD l10n

Mahay, here's the new pull request to add the bn-BD file. You'll probably want to take a look at the "description" field in the manifest.webapp file and provide an alternate translation there. You can leave it in a comment here or on the pull request and I'll get it to the right places. 

Otherwise you should just need to review that the strings from your original pull request made it up to Transifex and back into this new file OK.
Attachment #8462877 - Flags: review?(mahayalamkhan)
(Assignee)

Comment 6

4 years ago
ni? to l10n -- is there someone available who can take this review? (See comment #5 for notes.)
Flags: needinfo?(l10n)
Attachment #8461139 - Attachment mime type: application/octet-stream → text/plain
I'd point you to MAK, so you got the right person here.

MAK, did you do this kind of review process before? If not, here's how that works. First, you view the attachment, bugzilla will redirect you there when you visit https://bugzilla.mozilla.org/attachment.cgi?id=8462877. Check the changes in the "Files changed" tab, leave comments on the lines if needed.

Then go to the details, https://bugzilla.mozilla.org/attachment.cgi?id=8462877&action=edit, and set the 'review' flag to either + or -, depending on whether the change should land as is or not. It's also good to recap if you left comments in the pull request UI.
Flags: needinfo?(l10n)

Updated

4 years ago
Attachment #8462877 - Flags: review?(mahayalamkhan) → review-
Flags: needinfo?(mahayalamkhan)
(Assignee)

Comment 8

4 years ago
MAK, can I assume r+ once I make the change you left on the pull request?
Flags: needinfo?(mahayalamkhan)
(Assignee)

Comment 9

4 years ago
Comment on attachment 8462877 [details] [review]
PR - add bn-BD l10n

Updated PR with new description, ready for another look.
Attachment #8462877 - Flags: review- → review?(mahayalamkhan)

Updated

4 years ago
Attachment #8462877 - Flags: review?(mahayalamkhan) → review+
Flags: needinfo?(mahayalamkhan)
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
Master: https://github.com/mozilla-b2g/notes/commit/206046d3bddcdc2de33bbe7ee9e60d76c538ed87
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-b2g-v2.1: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S3 (29aug)
You need to log in before you can comment on or make changes to this bug.