Closed Bug 1042979 Opened 6 years ago Closed 6 years ago

Clean up unused imports, variables, and dead code in mochitest

Categories

(Testing :: Mochitest, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla34

People

(Reporter: akachkach, Assigned: akachkach)

Details

Attachments

(1 file, 1 obsolete file)

While working on structured logging, I found a couple unused imports, functions and variables in the mochitest files (and automationutils.py). We could probably also delete runtestsvmware.py since it wasn't updated since 2010, and doesn't seem to be used by anyone.
Updated the mochitest Makefile to remove the runtestsvmware.py test harness since it is outdated and not used anymore (+ VMWare doesn't support anymore some of the features required to run it).

Try push: https://tbpl.mozilla.org/?tree=Try&rev=875c34b0bd24
Attachment #8461150 - Attachment is obsolete: true
Attachment #8461506 - Flags: review?(ahalberstadt)
Comment on attachment 8461506 [details] [diff] [review]
0001-Bug-1042979-Clean-up-unused-imports-variables-and-de.patch

Review of attachment 8461506 [details] [diff] [review]:
-----------------------------------------------------------------

You rock :)
Attachment #8461506 - Flags: review?(ahalberstadt) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/38a505f2bcb1
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.