1042994 - Look Up Tool doesn't find apps starting with number

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Admin Tools, defect, P3)

Description

[Karen Ward [:kward]]

Try to search for 2+2=2048 app. Or 2048 apps.  No results are found but there are apps by this name.

Comment 1

[Rob Hudson [:robhudson]]

One reason is that if your search query is all numbers, it assumes you are looking up an app by ID. "2048" isn't an app ID so it gives up.

I tested "2+2=2048" and the app was in the list, albeit a bit further down than we might like. The reason is likely that "+" and "=" get parsed and ignored and you end up searching for "2 2 2048".

There's some improvements we can do here, though.

I'd recommend:
1. Remove the numeric database search by ID and add an elasticsearch term query on ID instead with a nice boost so that if it matches it gets boosted high. This will also remove some confusing logic on the backend in this view.
2. If we're not already, try a non-analyzed term query on name so exact matches find the app we're looking for.

I imagine both of these are straight-forward and should improve the lookup tool queries.

Comment 2

[Christopher Van Wiemeersch [:cvan]]

Let's just not only search by `id` when it's purely numeric. Or we can allow the search to search only by `id` when you specify `id=2048`.

Comment 3

[Karen Ward [:kward]]

Any news on a fix for this?

Comment 4

[krupa raj[:krupa]]

(In reply to Rob Hudson [:robhudson] from comment #1)
> One reason is that if your search query is all numbers, it assumes you are
> looking up an app by ID. "2048" isn't an app ID so it gives up.
> 
> I tested "2+2=2048" and the app was in the list, albeit a bit further down
> than we might like. The reason is likely that "+" and "=" get parsed and
> ignored and you end up searching for "2 2 2048".
> 
> There's some improvements we can do here, though.

Searching by ID is quite useful. Let us not remove that feature. Thanks!
> 
> I'd recommend:
> 1. Remove the numeric database search by ID and add an elasticsearch term
> query on ID instead with a nice boost so that if it matches it gets boosted
> high. This will also remove some confusing logic on the backend in this view.
> 2. If we're not already, try a non-analyzed term query on name so exact
> matches find the app we're looking for.
> 
> I imagine both of these are straight-forward and should improve the lookup
> tool queries.

Comment 5

[Karen Ward [:kward]]

Closed - this bug is no longer needed / change in strategy and way of working with FxOS precipitates closing these bugs