Closed Bug 1043088 Opened 7 years ago Closed 7 years ago

Enable forcing the usage of the static CRT in libffi's msvc wrapper

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla34

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file, 1 obsolete file)

This is required for AddressSanitizer builds with clang-cl.

The patch has been submitted upstream: https://github.com/atgreen/libffi/pull/123
Assignee: nobody → ehsan
Blocks: 1037058
Attachment #8461244 - Flags: review?(mh+mozilla)
I doubt the ifs are going to fly. Pretty sure you need to go the case route instead.
Comment on attachment 8461244 [details] [diff] [review]
Enable forcing the usage of the static CRT in libffi's msvc wrapper

Review of attachment 8461244 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ctypes/libffi/msvcc.sh
@@ +71,5 @@
>        cl="clang-cl"
>        safeseh=
>        shift 1
>      ;;
> +    -MT)

I'd rather go with a -DUSE_STATIC_RTL, like -DUSE_DEBUG_RTL, because -MT is an actual gcc flag, and who knows what libtool does with it. Probably nothing, but I'd rather be safe than sorry.
Attachment #8461244 - Flags: review?(mh+mozilla) → feedback+
Attachment #8461244 - Attachment is obsolete: true
Attachment #8465673 - Flags: review?(mh+mozilla)
Comment on attachment 8465673 [details] [diff] [review]
Enable forcing the usage of the static CRT in libffi's msvc wrapper; r=glanidum

Review of attachment 8465673 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ctypes/libffi/msvcc.sh
@@ +115,5 @@
>        defines="$defines $1"
>        shift 1
>      ;;
> +    -DUSE_STATIC_RTL)
> +      # Link against debug CRT.

s/debug/static/
Attachment #8465673 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/aaab67309068
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.