1043088 - Enable forcing the usage of the static CRT in libffi's msvc wrapper

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(no longer active)]

This is required for AddressSanitizer builds with clang-cl.

The patch has been submitted upstream: https://github.com/atgreen/libffi/pull/123

Comment 1

[(no longer active)]

Attachment: Enable forcing the usage of the static CRT in libffi's msvc wrapper

Comment 2

[Ryan VanderMeulen [:RyanVM]]

I doubt the ifs are going to fly. Pretty sure you need to go the case route instead.

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8461244 [details] [diff] [review]
Enable forcing the usage of the static CRT in libffi's msvc wrapper

Review of attachment 8461244 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ctypes/libffi/msvcc.sh
@@ +71,5 @@
>        cl="clang-cl"
>        safeseh=
>        shift 1
>      ;;
> +    -MT)

I'd rather go with a -DUSE_STATIC_RTL, like -DUSE_DEBUG_RTL, because -MT is an actual gcc flag, and who knows what libtool does with it. Probably nothing, but I'd rather be safe than sorry.

Comment 4

[(no longer active)]

Attachment: Enable forcing the usage of the static CRT in libffi's msvc wrapper; r=glanidum

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 8465673 [details] [diff] [review]
Enable forcing the usage of the static CRT in libffi's msvc wrapper; r=glanidum

Review of attachment 8465673 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ctypes/libffi/msvcc.sh
@@ +115,5 @@
>        defines="$defines $1"
>        shift 1
>      ;;
> +    -DUSE_STATIC_RTL)
> +      # Link against debug CRT.

s/debug/static/

Comment 6

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aaab67309068

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/aaab67309068

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/aaab67309068