Closed
Bug 104309
Opened 24 years ago
Closed 24 years ago
Contract id string for memory service should be in nsIMemory.idl
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
People
(Reporter: serhunt, Assigned: serhunt)
Details
Attachments
(1 file, 1 obsolete file)
|
1.23 KB,
patch
|
jband_mozilla
:
review+
jband_mozilla
:
superreview+
|
Details | Diff | Splinter Review |
It is currently in nsMemory.h which fact creates unnecessary dependency in the
plugin sample code which illustrates how to access the service. Moving its
definition into the nsIMemory.idl will fix the problem.
|
||
Comment 2•24 years ago
|
||
av: I'd vote for moving only the contractID and leaving the other two items in
place. This will help discourage clients from using the CID when they really
should only be using the contractID. I know lots of code in our tree exposes all
this stuff. But, I think it is wrong to do so - especially for a frozen highly
public service.
|
|
||
Comment 4•24 years ago
|
||
Comment on attachment 53375 [details] [diff] [review]
second try -- cid left alone
r/rs=jband
Attachment #53375 -
Flags: superreview+
Attachment #53375 -
Flags: review+
Attachment #53367 -
Attachment is obsolete: true
Checked in.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•