Closed
Bug 104311
Opened 23 years ago
Closed 23 years ago
Imagelib uses too much XPCOM
Categories
(Core :: Graphics: ImageLib, defect, P2)
Tracking
()
VERIFIED
FIXED
mozilla0.9.6
People
(Reporter: pavlov, Assigned: pavlov)
Details
Attachments
(2 files)
44.58 KB,
patch
|
bryner
:
review+
sspitzer
:
superreview+
|
Details | Diff | Splinter Review |
9.86 KB,
patch
|
bryner
:
review+
pavlov
:
superreview+
|
Details | Diff | Splinter Review |
Imagelib uses too much XPCOM/virtual functions internally. We can remove most of the internal functions and leave the XPCOM stuff only on the outside.
Assignee | ||
Comment 1•23 years ago
|
||
Assignee | ||
Comment 2•23 years ago
|
||
This patch removes the virtual function call use between the imgRequest and imgRequestProxy classes. I create a imgILoad interface that is only used by decoders to set/get the image that they are responsible for creating. With this patch, I make imgRequest no longer inherit from imgIRequest. I should rename imgRequest.[cpp/h] to imgLoad.[cpp/h], but I'll do that in another step as I would prefer to not lose version history. I will see if leaf can help out with this. I could probably also rename imgRequestProxy to imgRequest.. i'll rename files later.
Comment 3•23 years ago
|
||
Comment on attachment 53202 [details] [diff] [review] Patch to remove the internal virtual function crap r=bryner, with the corrections we talked about on irc
Attachment #53202 -
Flags: review+
Comment 4•23 years ago
|
||
Comment on attachment 53202 [details] [diff] [review] Patch to remove the internal virtual function crap sr=sspitzer stuart tells me he tested a whole bunch, including mailnews.
Attachment #53202 -
Flags: superreview+
Assignee | ||
Comment 5•23 years ago
|
||
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 6•23 years ago
|
||
Comment 7•23 years ago
|
||
sr=hyatt on 2nd patch
Assignee | ||
Updated•23 years ago
|
Attachment #53232 -
Flags: superreview+
Comment 8•23 years ago
|
||
Comment on attachment 53232 [details] [diff] [review] Remove the unused 'cx' param r=bryner
Attachment #53232 -
Flags: review+
Comment 9•23 years ago
|
||
Comment on attachment 53232 [details] [diff] [review] Remove the unused 'cx' param r=jag
Assignee | ||
Comment 10•23 years ago
|
||
2nd patch checked in
You need to log in
before you can comment on or make changes to this bug.
Description
•