bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Imagelib uses too much XPCOM

VERIFIED FIXED in mozilla0.9.6

Status

()

Core
ImageLib
P2
normal
VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: Stuart Parmenter, Assigned: Stuart Parmenter)

Tracking

Trunk
mozilla0.9.6
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

44.58 KB, patch
Brian Ryner (not reading)
: review+
(not reading, please use seth@sspitzer.org instead)
: superreview+
Details | Diff | Splinter Review
9.86 KB, patch
Brian Ryner (not reading)
: review+
Stuart Parmenter
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

17 years ago
Imagelib uses too much XPCOM/virtual functions internally.  We can remove most 
of the internal functions and leave the XPCOM stuff only on the outside.
(Assignee)

Comment 1

17 years ago
Created attachment 53202 [details] [diff] [review]
Patch to remove the internal virtual function crap
(Assignee)

Comment 2

17 years ago
This patch removes the virtual function call use between the imgRequest and 
imgRequestProxy classes.

I create a imgILoad interface that is only used by decoders to set/get the 
image that they are responsible for creating.

With this patch, I make imgRequest no longer inherit from imgIRequest. I should 
rename imgRequest.[cpp/h] to imgLoad.[cpp/h], but I'll do that in another step 
as I would prefer to not lose version history. I will see if leaf can help out 
with this.  I could probably also rename imgRequestProxy to imgRequest..  i'll 
rename files later.
Status: NEW → ASSIGNED
Keywords: patch
Priority: -- → P2
Target Milestone: --- → mozilla0.9.6
Comment on attachment 53202 [details] [diff] [review]
Patch to remove the internal virtual function crap

r=bryner, with the corrections we talked about on irc
Attachment #53202 - Flags: review+
Comment on attachment 53202 [details] [diff] [review]
Patch to remove the internal virtual function crap

sr=sspitzer

stuart tells me he tested a whole bunch, including mailnews.
Attachment #53202 - Flags: superreview+
(Assignee)

Comment 5

17 years ago
fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

17 years ago
Created attachment 53232 [details] [diff] [review]
Remove the unused 'cx' param

Comment 7

17 years ago
sr=hyatt on 2nd patch
(Assignee)

Updated

17 years ago
Attachment #53232 - Flags: superreview+
Comment on attachment 53232 [details] [diff] [review]
Remove the unused 'cx' param

r=bryner
Attachment #53232 - Flags: review+

Comment 9

17 years ago
Comment on attachment 53232 [details] [diff] [review]
Remove the unused 'cx' param

r=jag
(Assignee)

Comment 10

17 years ago
2nd patch checked in

Comment 11

17 years ago
Verified fix checked into lxr.mozilla.org
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.