Closed Bug 1043111 Opened 6 years ago Closed 6 years ago

Allow mState==DECODER_STATE_DORMANT in MediaDecoderStateMachine::ResetPlayback()

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: jwwang, Assigned: jwwang)

Details

Attachments

(1 file)

When FlushDecoding() [1] is called in dormant state, it will call ResetPlayback() and the assertion will fail at [2]. We should allow |mState==DECODER_STATE_DORMANT| in the assertion.


[1] http://hg.mozilla.org/mozilla-central/file/30907d52c4c2/content/media/MediaDecoderStateMachine.cpp#l2294

[2] http://hg.mozilla.org/mozilla-central/file/30907d52c4c2/content/media/MediaDecoderStateMachine.cpp#l1408
See comment 0 for the root cause.
Assignee: nobody → jwwang
Status: NEW → ASSIGNED
Attachment #8461280 - Flags: review?(kinetik)
Attachment #8461280 - Flags: review?(kinetik) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b97c05712090
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.