1043133 - [Dialer] Call with new taller hang up button

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Carol Huang [:Carol]]

Attachment: new_hangup_btn.jpg

Comment 1

[Carol Huang [:Carol]]

Attachment: Call_new_hangup_btn.pdf.zip

Attachment is the Visual spec for "CALL_new hang-up" btn.

Comment 2

[Germán Toro del Valle (:gtorodelvalle)]

Hi Carol, there are other scenarios when this new button heigh may also apply but we are not sure if it should, so it would be great if you could confirm it, please. I will include screenshots for affected every scenario in a sec.

Comment 3

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: [screenshot] callscreen-incoming-call.png

Incoming call scenario

Comment 4

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: [screenshot] callscreen-ongoing-call.png

Ongoing single call scenario

Comment 5

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: [screenshot] callscreen-second-incoming-call.png

Second incoming call scenario

Comment 6

[Jorge Prudencio [:jorgep]]

Attachment: [patch] callscreen-ongoing-call.png.png

Here is the solution to the incoming call scenario. I wait that you revise the other scenarios.

Comment 7

[Jorge Prudencio [:jorgep]]

Attachment: 22566.html

Comment 8

[Jorge Prudencio [:jorgep]]

Attachment: [patch] callscreen-ongoing-call.png

Comment 9

[Carol Huang [:Carol]]

Comment on attachment 8469172 [details]
[patch] callscreen-ongoing-call.png

Hi Germán & Jorge,

After a offline discussion with other visual designers, we decide not to do this visual change. 
We look over all the screens with buttons, especially with "2nd incoming call" screen, it looks packed with so many thick buttons on one screen.
Plus, in our common control, we have the same size of those buttons. If we only make the button change in Dialer, it would be inconsistent in the whole system.

@Germán
Thank you for the effort you've made and the time you spent. I'll be more careful on the change next time.

Comment 10

[Germán Toro del Valle (:gtorodelvalle)]

Hey Carol, no problem, of course ;) In fact, we started working on this bug before even confirming it with you because we used it as a suitable mentoring fist bug for Jorge (a new intern in Telefónica :) ), so it did its job :-)

Regarding your last comment, do you mean none of the changes requested in this bug applies, right? In that case, and just not to do it myself if I misunderstood, would you be so kind to evolve this bug to RESOLVED - INVALID, please? Thanks!

Comment 11

[Carol Huang [:Carol]]

@Germán
Thank you!
Yes, there will be none of changes for this bug.
--
We will file a new bug if there's new design in the future.