Closed Bug 1043170 Opened 5 years ago Closed 4 years ago

fxOS: Vertical Homescreen renders twice whenever the System App's launched

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect, P2)

ARM
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: mlee, Unassigned)

References

()

Details

(Keywords: perf, Whiteboard: [c=progress p= s= u=][systemsfe])

Attachments

(1 file)

Vertical Homescreen calls it's grid's render method twice during the System app's launch sequence which occurs at boot and whenever the System app's restarted (i.e. crash).

The first render call does unnecessary work because it never checks to see that there are 0 homescreen items (aka icons) at that time. Render should either be called only once or it should avoid all unnecessary work when there are 0 icons.

The render calls' stacktraces are available in the attached console.log output captured using Firefox Nightly WebIDE running fxOS Simulator 2.0:

	version		2.0.0.0-prerelease
	appbuildid	20140624000201
	platformbuildid	20140624000201
	platformversion	32.0a2
	geckobuildid	20140624000201
	geckoversion	32.0a2
	changeset	f118b45daada
   
Log captured via conditional breakpoint @ line 319 in gaia_grid/js/grid_view.js

	(function(){ try{ throw new Error(); } catch (e) { console.log ('\ngaia-grid.render.stacktrace\noptions: ', options, '\nitems: '+self.items.length + '\n' + e.stack); } return false;})();
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking-]
Whiteboard: [c=progress p= s= u=] → [c=progress p= s= u=][systemsfe]
Mass update: Resolve wontfix all issues with legacy homescreens.

As of 2.6 we have a new homescreen and having these issues open is confusing. All issues will block bug 1231115 so we can use that to re-visit any of these if needed.
Blocks: 1231115
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.