1043179 - Add ANONYMOUS_CONTRIBUTOR_EMAIL constant and document its purpose a little better

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Aki Rose Braun [:akirose]]

Atul made a great comment at https://github.com/mozilla/webmaker-landing-pages/pull/18/files#r15259072 regarding documenting anonymous contrib email.

Ah that's cool! Is that documented anywhere in the code? Seems like it might be nice to make it a named constant like ANONYMOUS_CONTRIBUTOR_EMAIL, and then at the definition of that constant, put a comment in that says what you just wrote, so that a curious reader could grep for the def'n and eventually find it, but that's just a suggestion (and perhaps something that's better filed as a separate bug rather than added on to this PR).

Comment 1

[Aki Rose Braun [:akirose]]

Attachment: https://github.com/mozilla/webmaker-landing-pages/pull/35

Comment 2

[Aki Rose Braun [:akirose]]

Comment on attachment 8464282 [details] [review]
https://github.com/mozilla/webmaker-landing-pages/pull/35

I ended up not putting an explanation comment because I felt like the constant name explained itself so well. Lmk if you think I should though, I defer to your experience on this one!

Comment 3

[Atul Varma [:atul]]

Nice! I agree that the name explains itself well. R+, I say!

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/webmaker-landing-pages

https://github.com/mozilla/webmaker-landing-pages/commit/61a8bfe634ffababede335eb88a3045e675a58b7
Bug 1043179 - Add ANONYMOUS_CONTRIBUTOR_EMAIL constant and document its purpose a little better

https://github.com/mozilla/webmaker-landing-pages/commit/d75b07bbc30a9a4a74ac4e0a412f7eeba6f23d0a
Merge pull request #35 from gesa/1043179/add-constant

Fixes Bug 1043179 - Add ANONYMOUS_CONTRIBUTOR_EMAIL constant and document its purpose a little better