1043271 - Enable Orangutan to send touch events at consistent intervals

Status: RESOLVED FIXED

(Testing Graveyard :: Orangutan, defect, P1)

Description

[Mason Chang [Inactive] [:mchang]]

For example, if i want to send a touch event every 10ms to match touch screen sample rates, it is not consistently sending a touch event every 10ms. I'd like to enable this feature so that orangutan sends touch events at the same rate that touch screens work.

Comment 1

[William Lachance (:wlach)]

After chatting about this with Jeff and Mason, we figured that the problem is that we're not watching the actual elapsed time during the drag to make sure that the events are occurring on the expected schedule, we're just assuming that things will happen instantaneously:

https://github.com/mozilla-b2g/orangutan/blob/master/orng.c#L219

Instead, every time we do a touch move event we should see where we are relative to the expected time of the drag and input touch events accordingly.

Comment 2

[William Lachance (:wlach)]

Attachment: Ensure drag event occurs over correct interval

This seems to do the right thing in my testing, though you probably need debug output to verify it. :)

Comment 3

[Mason Chang [Inactive] [:mchang]]

Comment on attachment 8461533 [details] [diff] [review]
Ensure drag event occurs over correct interval

Review of attachment 8461533 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me! Thanks for getting it so fast!

Comment 4

[Mason Chang [Inactive] [:mchang]]

Comment on attachment 8461533 [details] [diff] [review]
Ensure drag event occurs over correct interval

Review of attachment 8461533 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me! Thanks for getting it so fast!

Comment 5

[Mason Chang [Inactive] [:mchang]]

Hi Will, did this already land? If so, can you please resolve.

Comment 6

[William Lachance (:wlach)]

Oops forgot to push. Done now: https://github.com/mozilla-b2g/orangutan/commit/e9e38f526fd29eda06543ab5c3645eeca5e7e754