1043330 - Option collection values not honored, only keys

Status: RESOLVED WONTFIX

(Tree Management :: Treeherder: API, defect, P2)

Description

[Ed Morley [:emorley]]

Migrated from:
https://github.com/mozilla/treeherder-service/issues/172

geoelectric commented 23 days ago:

{
In the various sample data, as well as in the json format comment in model/derived/jobs.py, option_collection on the job object is a dict, where keys like "opt" or "debug" can be True or False.

However, in model/derived/refdata.py, the option_collection is transformed into a set via set(option_collection), which loses all the vals and only keeps the keys. Upshot is "debug: false" still marks debug as it's brought into the set.

            d = {"Foo": False}
            sd = set(d)
            sd

set(['Foo'])

It would be best to either filter any False values out of the collection dict prior to transforming it, or to specify a list instead of dict for that value (as the default value for the jobs.py reader uses)
}

Comment 1

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

To clarify, reason the "false" construct was used was due to bug 1043328 requiring a non-empty dict. However, since JSON has no concept of sets, would be best to have non-surprising behavior here.

Comment 3

[Ed Morley [:emorley]]

Submitting jobs/pushes via the API is now discouraged in favour of using Pulse (bug 1349182), so we're wontfixing API-specific issues.