Closed
Bug 1043374
Opened 10 years ago
Closed 10 years ago
Coorganizer and MentorRequest afterCreate hooks select ALL events
Categories
(Webmaker Graveyard :: Events, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cade, Assigned: cade)
Details
Attachments
(1 file)
https://github.com/mozilla/webmaker-events-service/blob/a04deae302efa59999a4ee637f0dda5bd1ec35ad/models/index.js#L140-L142 https://github.com/mozilla/webmaker-events-service/blob/a04deae302efa59999a4ee637f0dda5bd1ec35ad/models/index.js#L89-L91 These functions are silently evil. They should be generating queries for events with matching IDs, but they're really doing: SELECT * FROM `Events`; (lol) They need to be wrapped in a `where: {}` object
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → cade
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8461544 -
Flags: review?(jon)
Comment 2•10 years ago
|
||
Comment on attachment 8461544 [details] [review] https://github.com/mozilla/webmaker-events-service/pull/85 nice catch!
Attachment #8461544 -
Flags: review?(jon) → review+
Comment 3•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker-events-service https://github.com/mozilla/webmaker-events-service/commit/57b68f518459a8537a6e515e1d31c81820d5089e Bug 1043374 - Don't select all when looking up events for the Coorganizer and MentorRequest hooks
Assignee | ||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•