1043389 - Remove TextureFlags::ALLOC_FALLBACK

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Nicolas Silva [:nical]]

Now that we create and allocate the TextureClients in one place, we don't need to have a fallback branch in ContentClient if the TextureClient was successfully created but we failed to allocate it. Instead, we can handle this directly in TextureClient::CreateForDrawing: the method can fallback to BufferTextureClient by itself is allocation failed. This lets us remove a texture flag that didn't really have the same kind of use than the other flags which is nice.

The only notable change in behaviour is that other layer types will now also automatically have a fallback to BufferTextureClient, which is, I think, much better than cancelling rendering. It is still possible to fail to allocate the BufferTextureClient, but that should protect us against cases where we are out of "special" video memory while we still have normal memory left (like the gralloc allocation issues on keon/peak).

Comment 1

[Nicolas Silva [:nical]]

Attachment: Handle falling back to BufferTextureClient directly in TextureClient::CreateForDrawing

Comment 2

[Nicolas Silva [:nical]]

try https://tbpl.mozilla.org/?tree=Try&rev=5c751d77a26d

Comment 3

[Nicolas Silva [:nical]]

fixed build failures and pushed to try for the platforms that failed in the last push: https://tbpl.mozilla.org/?tree=Try&rev=1ccbd9a3fdf5

Comment 4

[Nicolas Silva [:nical]]

hopefully the last build fix  https://tbpl.mozilla.org/?tree=Try&rev=7d86dbb42717

Comment 5

[Nicolas Silva [:nical]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/591fdfc7734b

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/591fdfc7734b