1043403 - Support gmp-clearkey in Mochitest on B2G

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[(not currently active) Ted Mielczarek]

This turned out to be more of a hassle than I expected, so I'm punting this to a followup so we can get the desktop changes landed.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Hi Ted,
Is there a progress on this bug? We plan to enable EME on B2G and we need to enable mochitests first to provide a sold foundation for the porting job. Thanks.

Comment 2

[(not currently active) Ted Mielczarek]

I'm not working on this bug or planning on working on this bug. Sorry. Happy to advise someone else who would like to tackle it.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

For now, let's put focus on B2G. If we ever want to run EME On Android, let's spin off another bug.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1043403_support_clear_key_in_mochitest_on_b2g-v1.patch

1. include clearkey in the package of B2G since we need it anyway no matter running mochitests or a normal boot-up.
2. set gmp path to '/system/b2g/gmp-clearkey/0.1'. We don't need gmp-fake to run mochitests.

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 8579768 [details] [diff] [review]
1043403_support_clear_key_in_mochitest_on_b2g-v1.patch

Review of attachment 8579768 [details] [diff] [review]:
-----------------------------------------------------------------

I'm a little unclear why you say we need gmp-clearkey regardless of Mochitest or not, but I trust your judgement.

Comment 6

[(not currently active) Ted Mielczarek]

Could you file a follow-up for android and change the comment in runtestsremote.py to match?
https://dxr.mozilla.org/mozilla-central/source/testing/mochitest/runtestsremote.py#679

Comment 7

[JW Wang [:jwwang] [:jw_wang]]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #5)
> I'm a little unclear why you say we need gmp-clearkey regardless of
> Mochitest or not, but I trust your judgement.

We also need to play encrypted content on B2G as we do on the browser.
https://hg.mozilla.org/mozilla-central/file/1b6bf6612c0f/browser/installer/package-manifest.in#l933

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #6)
> Could you file a follow-up for android and change the comment in
> runtestsremote.py to match?
> https://dxr.mozilla.org/mozilla-central/source/testing/mochitest/
> runtestsremote.py#679

Sure. Bug 1149374 is filed.

Comment 9

[JW Wang [:jwwang] [:jw_wang]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa203f2d2443

Comment 10

[JW Wang [:jwwang] [:jw_wang]]

inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/4c8f68e6d01f

Comment 11

[(not currently active) Ted Mielczarek]

(In reply to JW Wang [:jwwang] from comment #7)
> We also need to play encrypted content on B2G as we do on the browser.
> https://hg.mozilla.org/mozilla-central/file/1b6bf6612c0f/browser/installer/
> package-manifest.in#l933

Oh, I didn't know we were shipping that. Thanks for the explanation. Do you think we'll ever need gmp-fake for testing purposes? The reason I punted on that was because it was a hassle to get it in the right place on non-desktop platforms.

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4c8f68e6d01f

Comment 13

[JW Wang [:jwwang] [:jw_wang]]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #11)
> Do you think we'll ever need gmp-fake for testing purposes? The reason I punted on
> that was because it was a hassle to get it in the right place on non-desktop
> platforms.

gmp-fake is needed to run Gtests. For now, we only run Gtests on desktop platforms (see also bug 932562 which has been pending for a while). So we don't need gmp-fake for non-desktop platforms for now.