1043409 - Test failure "Username has been saved - '' should equal 'bar" in testPasswordSavedAndDeleted.js

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect, P2)

Description

[Andreea Matei [:AndreeaMatei]]

This is failing on Aurora, several locales, all platforms.

The affected line:
http://hg.mozilla.org/qa/mozmill-tests/file/mozilla-aurora/firefox/tests/functional/testPreferences/testPasswordSavedAndDeleted.js#l79

Comment 1

[Andreea Matei [:AndreeaMatei]]

Daniel, can you please look into this? Thanks.

Comment 2

[Daniel Gherasim]

I can't reproduce this locally but on the CI machine (mm-ub-1310-64) this fails a lot.
I'll continue looking into this & come with more information.

Comment 3

[Daniel Gherasim]

Found out that this failure started on 30 june.

Here is a pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=afa67a2f7905&tochange=c3387c5ddba9

Last good build (with no failure):
ftp://ftp.mozilla.org/pub/firefox/tinderbox-builds/mozilla-central-linux64/1404036126/
Last bad build (fails very often):
ftp://ftp.mozilla.org/pub/firefox/tinderbox-builds/mozilla-central-linux64/1404085289/

I can also reproduce this with the latest nightly.
Not sure why it's only reproducible on CI, but I'll try to find a regressor soon.

Comment 4

[Daniel Gherasim]

That's the pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=0b5918ec6521&tochange=2f1356e9b56d

This is the regressor: bug 949617. There was the same problem with an internal test & the problem was that master password response to complete the inputs may come a bit delayed & here is their fix: https://bugzilla.mozilla.org/attachment.cgi?id=8447418&action=diff ..

I will come with a fix here soon too.

Comment 5

[Daniel Gherasim]

Attachment: v1.patch

Fixes the problem on the affected machines.

Comment 6

[Andrei Eftimie]

Comment on attachment 8462492 [details] [diff] [review]
v1.patch

Review of attachment 8462492 [details] [diff] [review]:
-----------------------------------------------------------------

So the problem for our bug is that the login items are now async.
Simple solution, I like it.

If this fixes the problem, lets get this in:

https://hg.mozilla.org/qa/mozmill-tests/rev/a89e0282a11a (default)
https://hg.mozilla.org/qa/mozmill-tests/rev/1c35e5bc75d9 (mozilla-aurora)

Comment 7

[Andrei Eftimie]

I don't think we need to backport this further.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8462492 [details] [diff] [review]
v1.patch

Review of attachment 8462492 [details] [diff] [review]:
-----------------------------------------------------------------

::: firefox/tests/functional/testPreferences/testPasswordSavedAndDeleted.js
@@ +77,5 @@
>  
>    controller.waitForElement(userField);
> +  expect.waitFor(() => userField.getNode().value === "bar",
> +                 "Username has been saved");
> +  expect.waitFor(() =>passField.getNode().value === "foo",

There is a missing blank after the => operator, and also you should use brackets around the comparison because it's not a simple return value.

Comment 9

[Daniel Gherasim]

Attachment: follow-up.patch

Comment 10

[Andrei Eftimie]

Comment on attachment 8468420 [details] [diff] [review]
follow-up.patch

Review of attachment 8468420 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good:
https://hg.mozilla.org/qa/mozmill-tests/rev/dfa389c936fd (default)
https://hg.mozilla.org/qa/mozmill-tests/rev/9c6ed92c41f5 (mozilla-aurora)