1043416 - create updated openh264 builds for Firefox 33 & 34

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

We should start tracking these build requests in bugs rather than private e-mail to minimize the chance of them getting lost for whatever reason (PTO, etc.). From e-mail today:
On 7/24/2014 10:35 AM, Ethan Hugg (ehugg) wrote:
>
> Hi Chris,
>
> These changes just landed on M-C and they change the GMP API:
>
> https://hg.mozilla.org/integration/mozilla-inbound/rev/fd72e28c6d38
> https://hg.mozilla.org/integration/mozilla-inbound/rev/1b3e953be799
> https://hg.mozilla.org/integration/mozilla-inbound/rev/6712067462a9
>
> This means that FF33 and FF34 now need different versions of the
> plugin.  On github/cisco/openh264 the "v1.1-Firefox33" is still the
> branch for FF33 (now Aurora), and the "master" branch is the one
> for FF34 - Nightly.
>
> So I believe we'll need you to build them both with separate naming
> and change the Nightly update to pull the FF34.  Tomorrow's Nightly
> will need the new build I believe.
>
> Let me know if this doesn't make sense.  Cheers.
>
>
> -EH

Comment 1

[Maire Reavy [:mreavy]]

Thanks, Ben.  Is there a way to flag when we need requests like this?  This particular request we need today so that tomorrow's Nightly works.

Comment 2

[[e-mail] (:bhearsum)]

(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #1)
> Thanks, Ben.  Is there a way to flag when we need requests like this?  This
> particular request we need today so that tomorrow's Nightly works.

File a bug like this and needinfo? catlee and I. If it doesn't get picked up, e-mail [e-mail].

Comment 3

[[e-mail] (:bhearsum)]

For posterity, builds are being done against the current tips of master and v1.1-Firefox33 on https://github.com/cisco/openh264
master rev is https://github.com/cisco/openh264/commit/300cceaabf0c423a3f464c963ac1b7abdae6e6b3
v1.1-Firefox33 rev is https://github.com/cisco/openh264/commit/b4504d4da483d83246633f7ad03b9f60400abaf6

Comment 4

[[e-mail] (:bhearsum)]

I've got new versions of the Linux plugins built:
1eb7aaa6c0046f39735899aa25bd593f630b1e098ff204cb385ce4e6121491e593e13a3564e33f58dfb9ea7016340c44b7538fdbf0e4fc9872a46d890cdc8640  openh264-linux32-master-300cceaabf0c423a3f464c963ac1b7abdae6e6b3.zip
760c69f7d9b6d8838dae4c083033f05cd592480499b8340d89b436462370310b989bb10fba6f9be92480b5fbc824125872c9d842ab6fb3a3b338d69efcf9a78a  openh264-linux32-v1.1-Firefox33-b4504d4da483d83246633f7ad03b9f60400abaf6.zip
d833d27b6d71fce1aa2ad3e59e3def3225ecd1dbbff83fba96e96b36ab8d0b09d1e97f2c226ec546fed04caca5023e8b47950cd01e52cd8306bd0d94f8372f5b  openh264-linux64-master-300cceaabf0c423a3f464c963ac1b7abdae6e6b3.zip
48cbaee44f1eacb6e6607cb31c881b07c8c3ff11a28713ac94f0c7d8766d1222c4c4065bf2ee70660a9674cd7a4881213328b806cae91bdc55f99430f72ab96f  openh264-linux64-v1.1-Firefox33-b4504d4da483d83246633f7ad03b9f60400abaf6.zip

I'm waiting for Justin to come around, who's been doing the Mac and Windows builds. Once I have them all in hand I'll e-mail them to you, Ethan.

Comment 5

[Justin Wood (:Callek)]

all files for win and mac uploaded to https://people.mozilla.org/~jwood/openh264/2014-07-24/

Comment 6

[[e-mail] (:bhearsum)]

(In reply to Justin Wood (:Callek) from comment #5)
> all files for win and mac uploaded to
> https://people.mozilla.org/~jwood/openh264/2014-07-24/

For those interested in the blow by blow - the master builds for  Windows and Mac builds were done against the wrong rev. They're being redone against the correct rev (from comment #3) now.

Comment 7

[Justin Wood (:Callek)]

And I just regen'd win and mac 'master' builds to be based on https://github.com/cisco/openh264/commit/300cceaabf0c423a3f464c963ac1b7abdae6e6b3 which I didn't the first go-thru

Comment 8

[[e-mail] (:bhearsum)]

OK, builds are all done, and I've mailed them Ethan. Full metadata is below for posterity:
➜  jul24  sha512sum *
1eb7aaa6c0046f39735899aa25bd593f630b1e098ff204cb385ce4e6121491e593e13a3564e33f58dfb9ea7016340c44b7538fdbf0e4fc9872a46d890cdc8640  openh264-linux32-master-300cceaabf0c423a3f464c963ac1b7abdae6e6b3.zip
760c69f7d9b6d8838dae4c083033f05cd592480499b8340d89b436462370310b989bb10fba6f9be92480b5fbc824125872c9d842ab6fb3a3b338d69efcf9a78a  openh264-linux32-v1.1-Firefox33-b4504d4da483d83246633f7ad03b9f60400abaf6.zip
d833d27b6d71fce1aa2ad3e59e3def3225ecd1dbbff83fba96e96b36ab8d0b09d1e97f2c226ec546fed04caca5023e8b47950cd01e52cd8306bd0d94f8372f5b  openh264-linux64-master-300cceaabf0c423a3f464c963ac1b7abdae6e6b3.zip
48cbaee44f1eacb6e6607cb31c881b07c8c3ff11a28713ac94f0c7d8766d1222c4c4065bf2ee70660a9674cd7a4881213328b806cae91bdc55f99430f72ab96f  openh264-linux64-v1.1-Firefox33-b4504d4da483d83246633f7ad03b9f60400abaf6.zip
fc725fbd21e10fc9ad3c8a7eba0d7ae7e61e47e387217c8e7954dbb6012f7713de39ea91738ab7a821f092d22ff7781dd1065f1f559c0fb7c55531e23804ad63  openh264-macosx32-master-300cceaabf0c423a3f464c963ac1b7abdae6e6b3.zip
a23e3708a4d779937ca5600f258ee5bdfd28b6e565dff26cdb7b706b63ac5455db167a821ceb4d2a3790ae73e5a9a0785732607768b915470efff40d58de2f7e  openh264-macosx32-v1.1-Firefox33-b4504d4da483d83246633f7ad03b9f60400abaf6.zip
0eac05de3b9dd939ece57450bcddf6fee04415a99744a0ce46ddb19c1205cbaf4d8c5a7b5efc2158c9fb257a7948024ed1604890b56382513922107e22273165  openh264-macosx64-master-300cceaabf0c423a3f464c963ac1b7abdae6e6b3.zip
57c2b23c97e32d21ff9f6f611803cfdf6ba4a97f7b403c031e979a79c1db1f507d9b72749824254892032f119a4d057cec926fbc4efb184c4f543dfd34ad72a2  openh264-macosx64-v1.1-Firefox33-b4504d4da483d83246633f7ad03b9f60400abaf6.zip
2a7930056448fb351916c4e6321f1862582933aef60157434fe3c7ba1e60507118b14d4156dc72991f165a1f273053824bb236f9d9a7941a5d47c96f48406da4  openh264-win32-master-300cceaabf0c423a3f464c963ac1b7abdae6e6b3.zip
b50f906d159364a6b2984224afccd1e25cc9361df4c8a2e65e76ed47f9a0f0b0d698cbb1137ac3dd5df52d3bb2ac2fcb3c2d91bce4f927b319645e75136dc128  openh264-win32-v1.1-Firefox33-b4504d4da483d83246633f7ad03b9f60400abaf6.zip
➜  jul24  ls -l *.zip
-rw-rw-r-- 1 bhearsum bhearsum 381160 Jul 24 11:50 openh264-linux32-master-300cceaabf0c423a3f464c963ac1b7abdae6e6b3.zip
-rw-rw-r-- 1 bhearsum bhearsum 380921 Jul 24 11:50 openh264-linux32-v1.1-Firefox33-b4504d4da483d83246633f7ad03b9f60400abaf6.zip
-rw-rw-r-- 1 bhearsum bhearsum 386057 Jul 24 11:50 openh264-linux64-master-300cceaabf0c423a3f464c963ac1b7abdae6e6b3.zip
-rw-rw-r-- 1 bhearsum bhearsum 385852 Jul 24 11:50 openh264-linux64-v1.1-Firefox33-b4504d4da483d83246633f7ad03b9f60400abaf6.zip
-rw-rw-r-- 1 bhearsum bhearsum 276611 Jul 24 13:23 openh264-macosx32-master-300cceaabf0c423a3f464c963ac1b7abdae6e6b3.zip
-rw-rw-r-- 1 bhearsum bhearsum 276532 Jul 24 13:15 openh264-macosx32-v1.1-Firefox33-b4504d4da483d83246633f7ad03b9f60400abaf6.zip
-rw-rw-r-- 1 bhearsum bhearsum 282746 Jul 24 13:25 openh264-macosx64-master-300cceaabf0c423a3f464c963ac1b7abdae6e6b3.zip
-rw-rw-r-- 1 bhearsum bhearsum 282436 Jul 24 13:15 openh264-macosx64-v1.1-Firefox33-b4504d4da483d83246633f7ad03b9f60400abaf6.zip
-rw-rw-r-- 1 bhearsum bhearsum 270282 Jul 24 13:25 openh264-win32-master-300cceaabf0c423a3f464c963ac1b7abdae6e6b3.zip
-rw-rw-r-- 1 bhearsum bhearsum 269964 Jul 24 13:15 openh264-win32-v1.1-Firefox33-b4504d4da483d83246633f7ad03b9f60400abaf6.zip

Comment 9

[[e-mail] (:bhearsum)]

Fluffy provided me with new URLs for all the builds, such as http://ciscobinary.openh264.org/openh264-win32-master-300cceaabf0c423a3f464c963ac1b7abdae6e6b3.zip. I've updated the information on our update server, which is now returing the new plugins for both 34.0 and 33.0.

I'm asking around on IRC for someone to test, but we're all done here now unless an issue comes up.

Comment 10

[[e-mail] (:bhearsum)]

Turns out I screwed up the addon id when I first updated the update server data. I used the old id ([e-mail]) instead of the new one (gmp-gmpopenh264). This has been fixed now.