1043442 - Improve wait in wait_for_capture_ready()

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Viorela Ioia [:viorela]]

Test test_camera_capture_photo.py has failed in the latest master build, because the the switch button from Camera to Video was not pressed. 
I was able to reproduce the failure locally by running the test, but not manually. It fails intermittently.
Probably this is a problem in our tests. We should check for the wait in https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/apps/camera/app.py#L84 and try to improve it.

Traceback (most recent call last):
File "/var/jenkins/1/workspace/flame.mozilla-central.ui.functional.smoke/.env/local/lib/python2.7/site-packages/marionette_client-0.7.11-py2.7.egg/marionette/marionette_test.py", line 170, in run
testMethod()
File "/var/jenkins/1/workspace/flame.mozilla-central.ui.functional.smoke/tests/python/gaia-ui-tests/gaiatest/tests/functional/camera/test_camera_capture_video.py", line 28, in test_capture_a_video
self.camera.record_video(3)
File "/var/jenkins/1/workspace/flame.mozilla-central.ui.functional.smoke/tests/python/gaia-ui-tests/gaiatest/apps/camera/app.py", line 59, in record_video
self.wait_for_video_capturing()
File "/var/jenkins/1/workspace/flame.mozilla-central.ui.functional.smoke/tests/python/gaia-ui-tests/gaiatest/apps/camera/app.py", line 105, in wait_for_video_capturing
self.wait_for_condition(lambda m: self.marionette.find_element(
File "/var/jenkins/1/workspace/flame.mozilla-central.ui.functional.smoke/tests/python/gaia-ui-tests/gaiatest/apps/base.py", line 54, in wait_for_condition
Wait(self.marionette, timeout).until(method, message=message)
File "/var/jenkins/1/workspace/flame.mozilla-central.ui.functional.smoke/.env/local/lib/python2.7/site-packages/marionette_client-0.7.11-py2.7.egg/marionette/wait.py", line 143, in until
cause=last_exc)
TimeoutException: TimeoutException: Timed out after 30.1 seconds

Gaia      c72257b2d27135bfcd68e89dd584182797784016
Gecko     https://hg.mozilla.org/mozilla-central/rev/06ac51c2b8a8
BuildID   20140724040205
Version   34.0a1
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014


Jenkins report: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame.mozilla-central.ui.functional.smoke/21/console

Comment 1

[Dylan Chun Wong [:dwong]]

the capture_video test was also failing, but I'm not sure what the cause is. Using the method used in the v2.0 build it also fails even though it registers as being tapped. I can't reproduce it manually.

Comment 3

[Viorela Ioia [:viorela]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22150

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8462527 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22150

This seems like a logical enhancement to the wait.

Comment 5

[Florin Strugariu [:Bebe]]

https://github.com/mozilla-b2g/gaia/commit/936f8a5be8e790756e66c2c4d11e54c275e897ef

Comment 6

[Zac C (:zac)]

This is actually a real bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1044317

Comment 7

[Viorela Ioia [:viorela]]

I believe that we are talking about 2 different bugs here. I added a fix because the test was failing before tapping the switch button from Camera to Video. After the fix was merged, the test passed, a video was recorded. 
In Bug 1044317, the test is failing after Tapping the Record video button, it is impossible to record a video. Screenshots of these 2 failures are different too: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame.mozilla-central.ui.functional.smoke/20/HTML_Report/ 
http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame.b2g-inbound.ui.functional.smoke/305/HTML_Report/

Comment 8

[Zac C (:zac)]

Ah! That makes more sense! :)