1043471 - Investigate failure in test_import_contacts_from_sdcard.py

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Viorela Ioia [:viorela]]

Test test_import_contacts_from_sdcard.py has failed in the latest master build.
The issue is not reproducible locally, by running the automated test. 
We should investigate and fix the issue. 

Traceback (most recent call last):
File "/var/jenkins/2/workspace/flame.mozilla-central.ui.functional.non-smoke/.env/local/lib/python2.7/site-packages/marionette_client-0.7.11-py2.7.egg/marionette/marionette_test.py", line 152, in run
self.setUp()
File "/var/jenkins/2/workspace/flame.mozilla-central.ui.functional.non-smoke/tests/python/gaia-ui-tests/gaiatest/tests/functional/contacts/test_import_contacts_from_sdcard.py", line 13, in setUp
self.device.manager.file_manager.remove_file(filename)
AttributeError: 'DeviceManagerADB' object has no attribute 'file_manager'

Jenkins report: http://jenkins1.qa.scl3.mozilla.com/job/flame.mozilla-central.ui.functional.non-smoke/

Comment 1

[Viorela Ioia [:viorela]]

I did some investigations and this test is failing because there are vcf files on sdcard, and the method should delete the existing files is wrong: https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/contacts/test_import_contacts_from_sdcard.py#L13
We should use the remove() method from file_manager.py instead. Also, this change is required in test_export_contacts_to_sdcard.py too: https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/contacts/test_export_contacts_to_sdcard.py#L17

Comment 2

[Viorela Ioia [:viorela]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22162

Comment 3

[Viorela Ioia [:viorela]]

(In reply to Viorela Ioia [:viorela] from comment #2)
> Created attachment 8462516 [details] [review]
> Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22162

ALso I tested this on desktopb2g and works as expected

Comment 4

[Florin Strugariu [:Bebe]]

https://github.com/mozilla-b2g/gaia/commit/d2c4dbc196ac35bd29d9c1e316edbcd50908d187