Closed Bug 1043526 Opened 11 years ago Closed 11 years ago

Remove Duplicate Environment Variables

Categories

(Socorro :: Infra, task)

x86_64
Linux
task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bramwelt, Assigned: bramwelt)

Details

It is confusing trying to find where to set or override an environment variable when working on the build system. Any overridden environment variables should be removed from the build scripts and/or Makefile and documented under "Building Socorro".
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Had to revert this. Even though leeroy passed this failed after merging. Looks like at least nose tests are getting bad credentials. from a good run: 00:01:04.619 env resource.postgresql.database_hostname=jenkins-pg92 secrets.postgresql.database_username=test secrets.postgresql.database_password=aPassword resource.postgresql.database_port=5432 resource.rabbitmq.host=rabbitmq-zlb.webapp.phx1.mozilla.com resource.rabbitmq.virtual_host=socorro-jenkins secrets.rabbitmq.rabbitmq_user=socorro-jenkins secrets.rabbitmq.rabbitmq_password=aPassword resource.elasticsearch.elasticsearch_urls=http://jenkins-es20:9200 resource.elasticsearch.elasticSearchHostname=jenkins-es20 PYTHONPATH="." /var/lib/jenkins/jobs/socorro-release/workspace/socorro-virtualenv/bin/coverage run /var/lib/jenkins/jobs/socorro-release/workspace/socorro-virtualenv/bin/nosetests socorro -s --with-xunit from the bad run: env resource.postgresql.database_hostname=localhost secrets.postgresql.database_username=test secrets.postgresql.database_password=aPassword resource.postgresql.database_port=5432 resource.rabbitmq.host=localhost resource.rabbitmq.virtual_host=/ secrets.rabbitmq.rabbitmq_user=guest secrets.rabbitmq.rabbitmq_password=guest resource.elasticsearch.elasticsearch_urls=http://localhost:9200 resource.elasticsearch.elasticSearchHostname=localhost PYTHONPATH="." /var/lib/jenkins/jobs/socorro-release/workspace/socorro-virtualenv/bin/coverage run /var/lib/jenkins/jobs/socorro-release/workspace/socorro-virtualenv/bin/nosetests socorro -s --with-xunit
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Yup, those are the defaults set in build.sh. I forgot to move over environment variables from socorro-github to socorro-release. I have since copied over the variables from socorro-github while keeping the old variables in place. This means that during this transition there will be multiple keys with the same values on socorro-release; for example: RABBITMQ_VHOST="socorro-jenkins" and rabbitmq_virtual_host="socorro-jenkins".
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 96
You need to log in before you can comment on or make changes to this bug.