1043534 - move netwerk/{sctp,srtp} completely over to moz.build

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Nathan Froyd [:froydnj]]

Just a couple easy CFLAGS definitions.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: move netwerk/{sctp,srtp} completely over to moz.build

Comment 2

[Michael Shal [:mshal]]

Comment on attachment 8461716 [details] [diff] [review]
move netwerk/{sctp,srtp} completely over to moz.build

Does this do anything different than the test in configure.in?

if test "$GNU_CC"; then
...
    CFLAGS="$CFLAGS -std=gnu99"


At least on my local machine, I get two '-std=gnu99' command-line arguments when compiling things in these directories. We might just be able to remove it from these files entirely.

If it is still necessary for some reason, then r+ since it looks otherwise fine.

Comment 3

[Nathan Froyd [:froydnj]]

That's a good point.

I think leaving it in would be better, since all this code is imported third-party stuff and the moz.build is slightly easier to verify if the settings there are close to what the upstream bits have.  Our jemalloc Makefiles set -std=gnu99, too, so there is at least some precedent.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2246b59a134a