send out review specific emails for app reviews, not generic commbadge ones

RESOLVED FIXED

Status

Marketplace
Reviewer Tools
P2
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: eviljeff, Assigned: ngoke)

Tracking

Avenir
Points:
---

Details

(Reporter)

Description

4 years ago
The generic commbadge email in the format:

#####
A user posted on a discussion of <app-name>.

<reviewer> wrote:
<notes>

If you have any questions about this review, you can contact the review  team by replying to this email or join us in #app-reviewers on  irc.mozilla.org. You can also follow the Apps Blog (http://blog.mozilla.com/apps) to stay updated on Marketplace news. You can also post to https://marketplace.firefox.com/comm/thread/<thread-id>
#####

is confusing for a developer because they didn't know there was a discussion; and wouldn't identify 'a user' as the actual reviewer of their submission.  It also looks like a computer generated email which is something we try to avoid as developers ignore them.

So instead we should send out the specific review emails as now, and don't send out the commbadge generic email.  The generic commbadge email would still be used for communication sent via /comm

Updated

4 years ago
Assignee: nobody → kngo
Priority: P1 → P3

Updated

4 years ago
Priority: P3 → P2
(Assignee)

Comment 2

4 years ago
STR:

With comm-dashboard flag on, for each reviewer action, check that the email sent out is largely the same as before. That the email is related to the action of the reviewer (approve, reject, ban, more info, tarako pass, etc).

For regular Commbadge notes, a generic Commbadge email should be sent to those involved in the thread.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Comment 3

4 years ago
QA: You can use https://marketplace.allizom.org/admin/mail to check out the emails.
You need to log in before you can comment on or make changes to this bug.