Closed Bug 1043589 Opened 10 years ago Closed 9 years ago

Autocomplete passwords does not work on central and aurora

Categories

(SeaMonkey :: Passwords & Permissions, defect)

Product:
SeaMonkey
Component:
Passwords & Permissions
Version:
SeaMonkey 2.30 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.29 unaffected, seamonkey2.30 fixed, seamonkey2.31 fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.31
Tracking Flags:
Tracking Status
seamonkey2.29 --- unaffected
seamonkey2.30 --- fixed
seamonkey2.31 --- fixed

People

(Reporter: adriank, Assigned: neil)

References

Details

Attachments

(1 file)

Proposed patch
1.73 KB, patch
philip.chee
: review+
iannbugzilla
: approval-comm-aurora+
Details | Diff | Splinter Review 
On central and since the merge this week on aurora too, the password autocompletion function stopped working (at least on Linux).
When you start typing the user name on a page (or just double click that field), then click on the suggested name, the password is not filled in even though it is still properly saved according to the Password Manager.

Afaics, atm there is no way to access the saved passwords other than through manual copy from the password manager.
Blocks: 949617
status-seamonkey2.29: --- → unaffected
status-seamonkey2.30: --- → affected
status-seamonkey2.31: --- → affected
OS: Linux → All
Hardware: x86_64 → All
Attached patch Proposed patch — — Splinter Review 
Assignee: nobody → neil
Status: NEW → ASSIGNED

        Attachment #8462991 -
        Flags: review?(philip.chee)

    
    

    
  
Comment on attachment 8462991 [details] [diff] [review]
Proposed patch

r=me

Bonus points for porting relevant bits from Bug 762593[1] (either here or in another patch/bug).

[1] https://hg.mozilla.org/mozilla-central/rev/a46b44af697f

        Attachment #8462991 -
        Flags: review?(philip.chee) → review+

    
    

    
  
(In reply to Philip Chee from comment #2)
> Bonus points for porting relevant bits from Bug 762593

It sends the messages directly to the web console, which is unhelpful.

    
    

    
  
(In reply to neil@parkwaycc.co.uk from comment #3)
> (In reply to Philip Chee from comment #2)
> > Bonus points for porting relevant bits from Bug 762593
> 
> It sends the messages directly to the web console, which is unhelpful.

I think the toolkit Error Console also gets notified:
>+    Services.console.logMessage(consoleMsg);
But perhaps we should wait for Bug 899983 and/or Bug 947471

    
    

    
  
(In reply to Philip Chee from comment #4)
> I think the toolkit Error Console also gets notified:
> >+    Services.console.logMessage(consoleMsg);
You're right, I didn't read the patch well enough.

    
    

    
  
(In reply to Philip Chee from comment #4)
> But perhaps we should wait for Bug 899983 and/or Bug 947471
Or even bug 983326 ;-)

    
    

    
  
Comment on attachment 8462991 [details] [diff] [review]
Proposed patch

[Triage Comment]
a=me for trunk and aurora (if needed)

        Attachment #8462991 -
        Flags: approval-comm-aurora+

    
    

    
  
Pushed comm-central changeset 58bff661b0f1.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago

          status-seamonkey2.31:
          affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.31

          You need to log in
          before you can comment on or make changes to this bug.