I noticed that the wallet dll was linking against xplib.lib. We need to update the code to use xpcom equivalents so we can remove this dependency. It is bad for a couple reasons, most importantly it's contribution to code bloat. We shouldn't be building with xplib anyway. I took xplib.lib out of the dll to see what undefined symbols occurred. It looks like XP_List is being used. I think you can swap that out with nsVoidArray. There were also a couple of XP_ASSERT references which can be replaced with NS_ASSERTION.
Status: ASSIGNED → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → FIXED
xplib dependencies have been taken out of wallet dll.
mscott can you verify please thanks
Status: RESOLVED → VERIFIED
Whiteboard: asked reporter
I examined the makefiles in wallet and didn't see any linkagae against xplib. This implies (at least to me) that the xplib dependency is gone. Marking as verified and clearing whiteboard.
Actually I take that back..Steve, can you clean up the linux makefiles to remove the xplib linkage too?
Which makefile are you referring to? I don't see any that contains xplib.
I thought I saw it in wallet\src. (isn't -lxp == xplib for linux?)
Sorry, I didn't know that. OK, I'll remove it, test it out on linux, and then check it in.
Linux change checked in.
You need to log in before you can comment on or make changes to this bug.