Closed
Bug 1043602
Opened 10 years ago
Closed 10 years ago
Use TYPE_SUBDOCUMENT instead of TYPE_SCRIPT for contentPolicyCheck in ImportManager
Categories
(Core :: DOM: Security, defect)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: ckerschb, Assigned: ckerschb)
References
Details
Attachments
(1 file)
|
1.46 KB,
patch
|
gkrizsanits
:
review+
|
Details | Diff | Splinter Review |
As discussed with geekboy and mrbkap on IRC, we should use TYPE_SUBDOCUMENT for the contentPolicyCheck and not TYPE_SCRIPT [1]. Note that the channelPolicy, attached to the channel right underneath uses the correct contentPolicyType: TYPE_SUBDOCUMENT. [1] http://mxr.mozilla.org/mozilla-central/source/content/base/src/ImportManager.cpp#212
|
Assignee | |
Comment 1•10 years ago
|
||
Shouldn't affect the outcome, to make sure lets run it through try, to make sure everything is fine: https://tbpl.mozilla.org/?tree=Try&rev=b37be57d9af0
Attachment #8461913 -
Flags: review?(gkrizsanits)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8461913 [details] [diff] [review] bug_1043602.patch Review of attachment 8461913 [details] [diff] [review]: ----------------------------------------------------------------- Sorry for the lag, I was on PTO... and thanks for spotting/fixing this!
Attachment #8461913 -
Flags: review?(gkrizsanits) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/aca3cef28edf
Target Milestone: --- → mozilla34
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/aca3cef28edf
Assignee: nobody → mozilla
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•