1043615 - [L10n][Settings] Clean up mozL10n.get uses in Settings app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

Settings use mozL10n.get in 44 places and mozL10n.localize in 31 and mozL10n.translate in one.

The goal is to replace localize with setAttributes, remove the translate and minimize the amount of gets.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Actually, there are at least 100 more mozL10n.localize use cases. Just harder to grep. They use utils.js@localize and var l10n = navigator.mozL10n; l10n.localize

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: pull request

Oh, this is going to be fun.

Arthur, the pull request cleans all mozL10n.localize and mozL10n.translate uses in Settings and moves majority of mozL10n.get to DOM l10nId based approach which makes the code retranslatable.

There are no changes in logic, but a lot of files are affected.

If you prefer me to somehow chunk it to make review process easier, let me know!

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8462800 [details] [review]
pull request

Thank you for cleaning this up, Zibi! That was a lot of work.

Overall it looks good to me. There are a few minor issues to be addressed. Please check github for details.

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8462800 [details] [review]
pull request

Cool! That was easy to update. I pushed updates to the PR and triggered new try builds.

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Arthur, one test failed:

 - settings/test/unit/about_test.js | about > checkForUpdates > getting response for system update > check-error | expected 'check-error' to equal 'check-error-http-200'

What should I do with the check-error vs. check-error-* ? Update the test?

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

I think we could change the expected value to `check-error` instead of errors[i].

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

makes sense. Updated the PR

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8462800 [details] [review]
pull request

r=me with one last comment addressed, thank you!

Comment 9

[Zibi Braniecki [:zbraniecki][:gandalf]]

Thanks Arthur the great review!

Commit: https://github.com/mozilla-b2g/gaia/commit/eced8a617b6fde7962e1746f4e65336aaddd86c3
Merge: https://github.com/mozilla-b2g/gaia/commit/746dbbf5665c3ed8c4baad8474c011966e706ccd

Comment 10

[Zibi Braniecki [:zbraniecki][:gandalf]]

Follow up patch to update L10n ID's - https://github.com/mozilla-b2g/gaia/commit/9689218473b6fc4dd927ad6aa7b06c05f0843824