Closed
Bug 1043679
Opened 10 years ago
Closed 10 years ago
the "Phone" app is called "Dialer" at the top of the screen
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S1 (1aug)
People
(Reporter: dbaron, Assigned: kgrandon)
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
Gaia has just changed to showing the app in the bar at the top of the screen. But the "Phone" app (the name "Phone" is used in the app-switcher and on the icon) is called "Dialer" (a different name) at the top of the screen. The name for the app ought to be consistent between different parts of the UI. (Not sure if this should be filed in Gaia::Dialer, Gaia::System, or Gaia::System::Window Mgmt.)
|
||
Updated•10 years ago
|
Whiteboard: [systemsfe]
|
Assignee | |
Comment 1•10 years ago
|
||
Shouldn't be too hard to fix, I'll take a look.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•10 years ago
|
||
Etienne - this seems to fix the problem for me, and I think it will also let apps do cool stuff still? Let me know what you think. If you just want to remove some more stuff we can also.
Attachment #8462414 -
Flags: review?(etienne)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8462414 [details] [review] Github pull request Looking good, can you remove the app.name = ... from the tests and just use the fakeAppWithName for those ?
Attachment #8462414 -
Flags: review?(etienne) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Master: https://github.com/mozilla-b2g/gaia/commit/accc02d27cb8bbcb987d48e5dd28d29929317b7f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
||
Updated•10 years ago
|
Target Milestone: --- → 2.1 S1 (1aug)
You need to log in
before you can comment on or make changes to this bug.
Description
•