1043708 - [music] Close button in search bar should not have gradient background

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Amy Lee [:amylee] UX]

Build Information
Device: Flame
Gaia      29266e18c35f4e72e35f1bba0e34f2fb6b995cc3
Gecko     https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/178fe2efc41d
BuildID   20140724000201
Version   32.0
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
B1TC00011220

Description

Close button in search bar should not have gradient background

Steps to Reproduce:

1. Open music app
2. Scroll up to search music bar


Expected Results:

Close text button with no background gradient

Actual Results:

Close text button with a background gradient




Reproduction Frequency:

Comment 1

[Johan Lorenzo [:jlorenzo]]

It also affects today's 2.1. Amy, would UX you block on that for 2.0?

Comment 2

[Amy Lee [:amylee] UX]

(In reply to Johan Lorenzo [:jlorenzo] from comment #1)
> It also affects today's 2.1. Amy, would UX you block on that for 2.0?

Hi Johan, 

Hung is the visual designer working on the music app so I'll let him comment if it's a blocker.

Comment 3

[Hung Nguyen]

Hi Johan 

This should be consider a blocker. The gradient button breaks the visual language and makes the app look "amateur". 

Thanks
Hung

Comment 4

[Johan Lorenzo [:jlorenzo]]

[Blocking Requested - why for this release]: As per comment 3.

Comment 5

[Sherman Chen [:chens] (inactive)]

Attachment: Pull request

https://github.com/mozilla-b2g/gaia/pull/22241

Comment 6

[Dominic Kuo [:dkuo]]

Comment on attachment 8463806 [details] [review]
Pull request

Thanks Sherman, this looks good to me!

Comment 7

[Jason Smith [:jsmith]]

QA Wanted to get a screenshot.

Comment 8

[Chris Kreinbring [:CKreinbring]]

Attachment: Screenshot of gradient Close button

Comment 9

[Hung Nguyen]

Attachment: Intended_Design.png

I've attached a mock up of the intended design. 

Thanks!

Comment 10

[Hema Koka [:hema]]

Not a blocker: https://wiki.mozilla.org/B2G/Triage

Comment 11

[Sherman Chen [:chens] (inactive)]

Attachment: MusicSearchButton.png

Screenshot of no gradient search button

Comment 12

[Mike Habicher [:mikeh] (high bugzilla latency)]

I tried to get 1.4 running on my dolphin to verify this, but it looks like the device is dead. :(

Comment 13

[Mike Habicher [:mikeh] (high bugzilla latency)]

Confirmed gradient on Close button on:
- gecko: b2g30_v1_4:188372:3c780088aae4
- gaia: v1.4:77e73c20c180fdf7f37247fa60a3d1886cdc726e

The gradient was -not- observed on the build flashed with the default dolphin build:
- gecko: 30.0 / 20140731085113
- gaia: 1.4 / 393d7293 (dated Mon Jul 7 16:10:39 2014 -0400)

Comment 14

[Sherman Chen [:chens] (inactive)]

Merged to v2.0 
https://github.com/mozilla-b2g/gaia/commit/f6702e2aab77ac144955b3cbc042483b1c5eefa7

Comment 15

[Jason Smith [:jsmith]]

(In reply to Sherman Chen [:chens] from comment #14)
> Merged to v2.0 
> https://github.com/mozilla-b2g/gaia/commit/
> f6702e2aab77ac144955b3cbc042483b1c5eefa7

Sherman - I think this needs approval before this can land on 2.0. Also, did this patch land on master here? I don't see the commit here for the landing on master.

Comment 16

[Sherman Chen [:chens] (inactive)]

Ah, I didn't notice this need approval. And your are right, this patch didn't goes to master

Comment 17

[Dominic Kuo [:dkuo]]

Sherman, I think we should revert the commit in v2.0 then land it on master first, right? after that request the approval for v2.0.

Comment 18

[Sherman Chen [:chens] (inactive)]

Backout from v2.0: 
https://github.com/mozilla-b2g/gaia/commit/640ce38ca03f1e26a4524ff4215b8b3f7731e2f0

Comment 19

[Sherman Chen [:chens] (inactive)]

Attachment: Pull request to master

Hi Dominic, 

Thanks for the reminder, I have created another pull request to master, could you review it? thanks.

Comment 20

[Dominic Kuo [:dkuo]]

Comment on attachment 8474444 [details] [review]
Pull request to master

The patch is the same as the reverted one so looks good to me! I didn't actually test it but I believe you have verified the patch works, thanks!

Comment 21

[Dominic Kuo [:dkuo]]

master:f1ed7c4ae388c6a21aa20996803680fad9512248

Comment 22

[Elie]

Attachment: VIDEO0054.mp4

This issue has been successfully verified on Flame 2.1:
Gaia-Rev        1bdd49770e2cb7a7321e6202c9bf036ab5d8f200
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/db893274d9a6
Build-ID        20141125001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2