1043719 - A long-press event is fired in the middle of a pinch gesture if the second touchstart is cancelled

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

STR:
1. Load http://people.mozilla.org/~kgupta/touch.html
2. Check the "second touch-start" box
3. Do a pinch while watching console output (make sure you put the two fingers down at the same time, or as close to it as possible)

Expected:
- No contextmenu event is fired

Actual:
- Contextmenu event is fired amid the slew of touchmoves.

The reason is that the touch block starting at the second touch gets cancelled, so those events don't go through to the GEL code. The long-press timer that was scheduled from the first touch never gets cancelled as a result.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Technically this was fixed in bug 1043689 because the state in the GEL gets reset to none. However the pending long-tap and max-tap timeouts are still active needlessly. It makes sense to cancel them when resetting the state.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Cancel pending timeouts

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e76cbce3289a

Comment 4

[Ed Morley [:emorley]]

Backed out for crashes:
https://tbpl.mozilla.org/php/getParsedLog.php?id=45179365&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=45178865&tree=Mozilla-Inbound

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/eeb7077c11ff

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Interesting; that gtest passes for me locally. I'll investigate.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Was able to reproduce after updating my local code. Filed bug 1048888 for the underlying problem. Try push with both patches: https://tbpl.mozilla.org/?tree=Try&rev=f4fa0f5c97e4

Comment 7

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/b2g-inbound/rev/70433c52a9c6

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/70433c52a9c6