1043723 - Make Marionette work with Mulet when it's running Gaia

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Jonathan Griffin (:jgriffin)]

Marionette works with Mulet at present when Mulet is just acting like Firefox, but it fails when Mulet is running Gaia.  This is because its appname is "Firefox", but it lacks the new-tab behavior expected by:

http://mxr.mozilla.org/mozilla-central/source/testing/marionette/marionette-server.js#2604

In the case of Mulet+Gaia, we don't want a new tab, we just want to use the existing singular chrome window.

There's nothing in Services.appinfo that can be used to distinguish Mulet from Firefox AFAICT, but we can probably gate this on the chrome url that's loaded.

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: Make Marionette work with Mulet+Gaia,

We can just rely on window.gBrowser not existing, it turns out.

Comment 2

[Jonathan Griffin (:jgriffin)]

pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=2d0e399079fa

Comment 3

[David Burns :automatedtester]

Comment on attachment 8462254 [details] [diff] [review]
Make Marionette work with Mulet+Gaia,

Review of attachment 8462254 [details] [diff] [review]:
-----------------------------------------------------------------

The r= in the commit message needs updating

Comment 4

[Jonathan Griffin (:jgriffin)]

Hmm this caused a perma-fail in test_click_chrome, back to the drawing board.

Comment 5

[Jonathan Griffin (:jgriffin)]

take two: https://tbpl.mozilla.org/?tree=Try&rev=3d54bff160fe

Comment 6

[Jonathan Griffin (:jgriffin)]

Attachment: Make Marionette work with Mulet+Gaia,

This try run is looking good.  The last patch failed unit tests that opened new windows with custom XUL files, since those wouldn't have win.gBrowser defined.  This mechanism should be a bit more robust.

Comment 7

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e1601237530e

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e1601237530e