Make Marionette work with Mulet when it's running Gaia

RESOLVED FIXED in mozilla34

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jgriffin, Assigned: jgriffin)

Tracking

unspecified
mozilla34
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

5 years ago
Marionette works with Mulet at present when Mulet is just acting like Firefox, but it fails when Mulet is running Gaia.  This is because its appname is "Firefox", but it lacks the new-tab behavior expected by:

http://mxr.mozilla.org/mozilla-central/source/testing/marionette/marionette-server.js#2604

In the case of Mulet+Gaia, we don't want a new tab, we just want to use the existing singular chrome window.

There's nothing in Services.appinfo that can be used to distinguish Mulet from Firefox AFAICT, but we can probably gate this on the chrome url that's loaded.
Assignee

Comment 1

5 years ago
We can just rely on window.gBrowser not existing, it turns out.
Attachment #8462254 - Flags: review?(mdas)
Assignee

Updated

5 years ago
Attachment #8462254 - Flags: review?(mdas) → review?(dburns)
Comment on attachment 8462254 [details] [diff] [review]
Make Marionette work with Mulet+Gaia,

Review of attachment 8462254 [details] [diff] [review]:
-----------------------------------------------------------------

The r= in the commit message needs updating
Attachment #8462254 - Flags: review?(dburns) → review+
Assignee

Comment 4

5 years ago
Hmm this caused a perma-fail in test_click_chrome, back to the drawing board.
Assignee

Comment 6

5 years ago
This try run is looking good.  The last patch failed unit tests that opened new windows with custom XUL files, since those wouldn't have win.gBrowser defined.  This mechanism should be a bit more robust.
Attachment #8462832 - Flags: review?(dburns)
Assignee

Updated

5 years ago
Attachment #8462254 - Attachment is obsolete: true
Attachment #8462832 - Flags: review?(dburns) → review+
https://hg.mozilla.org/mozilla-central/rev/e1601237530e
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.