Remove the old WebRTC indicator and Apps icons from Toolbar.png & Co.

RESOLVED FIXED

Status

()

Firefox
Theme
RESOLVED FIXED
4 years ago
a year ago

People

(Reporter: ttaubert, Unassigned)

Tracking

Trunk
Points:
---
Dependency tree / graph
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed by bug 1347543)

(Reporter)

Description

4 years ago
Bug 1037415 removed the indicator itself but didn't remove its icon from Toolbar.png. Let's do that here and also update CSS rules for the icons to the right of it.
Flags: firefox-backlog+
(Reporter)

Comment 1

4 years ago
This looks like a great bug to mentor. Any takers?
Component: General → Theme
Whiteboard: [good first bug][lang=css]

Comment 2

4 years ago
I would like to work on that. Can you assignee to me?

Comment 3

4 years ago
It seems to be ok if I want to work on it. Isn't it?
Flags: needinfo?(nobody)

Updated

4 years ago
Flags: needinfo?(nobody) → needinfo?(ttaubert)
(Reporter)

Comment 4

4 years ago
It's yours!
Assignee: nobody → lukas.silvestre
Status: NEW → ASSIGNED
Flags: needinfo?(ttaubert)
(Reporter)

Comment 5

4 years ago
(In reply to Hanna from comment #2)
> I would like to work on that. Can you assignee to me?

Sorry Hanna, I must have missed that message two months ago :/

Comment 6

4 years ago
Hi Tim,
I need some help as this is my first bug here.
I tried using RTC between Firefox and Chrome but I could not see the icon (http://i.imgur.com/NHidncc.png) on Firefox.
Flags: needinfo?(ttaubert)
(Reporter)

Comment 7

4 years ago
Florian, would you be able to mentor Lucas here?
Flags: needinfo?(ttaubert) → needinfo?(florian)
(In reply to Tim Taubert [:ttaubert] from comment #7)
> Florian, would you be able to mentor Lucas here?

If we are sure we want to do this, I can mentor. The reason I have doubts is that in the past I've heard that the best way to handle this situation of an icon in Toolbar.png not being needed is to ensure UX folks know about it, so that the next time they need to add an icon to that file, they just replace it instead of expending the size of the image. That solution would avoid having to change the CSS rules for all the images currently to the right of the removed icon.
Flags: needinfo?(florian)
(Reporter)

Comment 9

4 years ago
Hmm. That sounds reasonable. Sorry Lucas, didn't know we usually do it that way!

So who from UX should we ping about this?

Guess we should close this bug then?
Assignee: lukas.silvestre → nobody
Status: ASSIGNED → NEW
Whiteboard: [good first bug][lang=css]

Comment 10

4 years ago
No problem at all.
I'm gonna look for another one to work on ;)
Looks like this icon is still around. Also, bug 1207424 made the Apps icon obsolete.
Flags: needinfo?(shorlander)
Summary: Remove the old webrtc indicator's icon from Toolbar.png → Remove the old WebRTC indicator and Apps icons from Toolbar.png & Co.
Status: NEW → RESOLVED
Last Resolved: a year ago
Depends on: 1347543
Flags: needinfo?(shorlander)
Resolution: --- → FIXED
Whiteboard: fixed by bug 1347543
You need to log in before you can comment on or make changes to this bug.