Closed Bug 1043870 Opened 7 years ago Closed 6 years ago

Intermittent failing test, TEST-UNEXPECTED-FAIL | /builds/slave/test/gaia/apps/system/test/marionette/homescreen_navigation_test.js | Homescreen navigation > Going to the homescreen and back to a warm app

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kgrandon, Assigned: mikehenrty)

References

Details

(Keywords: intermittent-failure, Whiteboard: [systemsfe])

Attachments

(2 files)

46 bytes, text/x-github-pull-request
vingtetun
: review+
vingtetun
: feedback+
Details | Review
46 bytes, text/x-github-pull-request
apastor
: review+
Details | Review
Homescreen navigation > Going to the homescreen and back to a warm app:
16:40:29     INFO -    AssertionError: we got 3 reflows instead of 2
16:40:29     INFO -        at Context.<anonymous> (/builds/slave/test/gaia/apps/system/test/marionette/homescreen_navigation_test.js:77:12)
16:40:29     INFO -        at callFn (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:223:21)
16:40:29     INFO -        at Test.Runnable.run (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:216:7)
16:40:29     INFO -        at Runner.runTest (/builds/slave/test/gaia/node_modules/mocha/lib/runner.js:373:10)
16:40:29     INFO -        at /builds/slave/test/gaia/node_modules/mocha/lib/runner.js:451:12
16:40:29     INFO -        at next (/builds/slave/test/gaia/node_modules/mocha/lib/runner.js:298:14)
16:40:29     INFO -        at /builds/slave/test/gaia/node_modules/mocha/lib/runner.js:308:7
16:40:29     INFO -        at next (/builds/slave/test/gaia/node_modules/mocha/lib/runner.js:246:23)
16:40:29     INFO -        at /builds/slave/test/gaia/node_modules/mocha/lib/runner.js:270:7
16:40:29     INFO -        at done (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:185:5)
16:40:29     INFO -        at callFn (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:228:7)
16:40:29     INFO -        at Hook.Runnable.run (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:216:7)
16:40:29     INFO -        at next (/builds/slave/test/gaia/node_modules/mocha/lib/runner.js:258:10)
16:40:29     INFO -        at /builds/slave/test/gaia/node_modules/mocha/lib/runner.js:270:7
16:40:29     INFO -        at done (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:185:5)
16:40:29     INFO -        at /builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:199:9
16:40:29     INFO -        at Object.executeHook (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:369:18)
16:40:29     INFO -        at process._tickCallback (node.js:415:13)

https://tbpl.mozilla.org/php/getParsedLog.php?id=44556401&tree=Gaia-Try
I don't think bug 1034347 is related. AFAIK will-chance doesn't prevent reflows, it's triggered in a later stage in the pipeline. You'd have to check with layout to be sure.
This started failing too frequently, so we need to disable it for now:

https://tbpl.mozilla.org/php/getParsedLog.php?id=44677170&tree=Gaia-Try
https://tbpl.mozilla.org/php/getParsedLog.php?id=44677676&tree=Gaia-Try

Disabled in master: https://github.com/mozilla-b2g/gaia/commit/fa47621eca7b41c25f1f315440707f7270df9812

Ni? on Etienne for awareness.
Flags: needinfo?(etienne)
Keywords: leave-open
should we also disable it on v2.0? it seems always red on v2.0 branch.
Flags: needinfo?(kgrandon)
Sure, for stuff like this you can just uplift and do a=testonly or npotb. I've gone ahead and crafted a patch for 2.0 and uplifted: https://github.com/mozilla-b2g/gaia/commit/13978cf2230652274969536322378d448fd142a4
Flags: needinfo?(kgrandon)
Attached file Gaia PR
This is proving *really* stable locally. Doing some try-runs now.

But in the meantime... do we still need .homescreen in overflow:hidden? It's causing extra reflows when we scale the homescreen.
Assignee: nobody → etienne
Attachment #8493164 - Flags: feedback?(21)
Flags: needinfo?(etienne)
Comment on attachment 8493164 [details] [review]
Gaia PR

I don't remember exactly why I kept the overflow: hidden on the homescreen so f+ until I remember.
Attachment #8493164 - Flags: feedback?(21) → feedback+
Comment on attachment 8493164 [details] [review]
Gaia PR

rebased and tested the homescreen transition with various scrolling position etc...
moving to review!
Attachment #8493164 - Flags: review?(21)
https://github.com/mozilla-b2g/gaia/commit/055c380b17ae0b7e18f4886d3988eca96d6c2048
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Something has caused this bug to re-appear. Re-opening this bug.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Etienne and Michael, I suspect either one of you caused this test bustage from either bug 1220204 or bug 1222334. Can you take a look and figure out if that's the case?
Flags: needinfo?(mhenretty)
Flags: needinfo?(etienne)
Nigel, I don't think either of our commits caused this. Both reverts still showed the test failing often. Could this be related to bug 1225465?
Flags: needinfo?(mhenretty) → needinfo?(nigelbabu)
Oh joy. This means we need to widen the net for potential candidates :(
Flags: needinfo?(nigelbabu)
This is perma-failing now. We should really fix it. :/
It's weird because a test is failing now that we have *less* reflows than expected. An improvement in performance should not cause a failure.

Stealing.
Assignee: etienne → mhenretty
Blocks: 1222215
Flags: needinfo?(etienne)
Whiteboard: [systemsfe]
This just makes the improved reflow performance not cause an error.
Attachment #8692560 - Flags: review?(apastor)
Comment on attachment 8692560 [details] [review]
[Gaia PR] relax reflow check

<= 2 sounds better than === 2 to me :)
Attachment #8692560 - Flags: review?(apastor) → review+
master: https://github.com/mozilla-b2g/gaia/commit/ff4848cc7d424693220f0f7d57d5250b0ee5d374
Status: REOPENED → RESOLVED
Closed: 7 years ago6 years ago
Resolution: --- → FIXED
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.