Closed
Bug 1043898
Opened 11 years ago
Closed 11 years ago
MIR: Remove a few getOperand(0) useless calls in some unary instructions
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: bbouvier, Assigned: bbouvier)
Details
Attachments
(2 files)
5.11 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
7.10 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
It sounds to me that "operand" isn't more eloquent than "input", so let's just
use input instead.
Attachment #8462486 -
Flags: review?(jdemooij)
Assignee | ||
Comment 2•11 years ago
|
||
Again, num() isn't really eloquent and is used only in one place for MRound, MFloor and MCeil.
MComputeThis overrides input(), which isn't caught by the compiler but is unnecessary.
Attachment #8462488 -
Flags: review?(jdemooij)
Updated•11 years ago
|
Attachment #8462486 -
Flags: review?(jdemooij) → review+
Updated•11 years ago
|
Attachment #8462488 -
Flags: review?(jdemooij) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/182850749379
https://hg.mozilla.org/mozilla-central/rev/43cce527da0e
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•