MIR: Remove a few getOperand(0) useless calls in some unary instructions

RESOLVED FIXED in mozilla34

Status

()

Core
JavaScript Engine: JIT
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bbouvier, Assigned: bbouvier)

Tracking

unspecified
mozilla34
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8462486 [details] [diff] [review]
Remove MNot's operand() and use input() instead

It sounds to me that "operand" isn't more eloquent than "input", so let's just
use input instead.
Attachment #8462486 - Flags: review?(jdemooij)
(Assignee)

Comment 2

3 years ago
Created attachment 8462488 [details] [diff] [review]
Remove num() methods and use input() instead, remove MComputeThis' overriding input()

Again, num() isn't really eloquent and is used only in one place for MRound, MFloor and MCeil.

MComputeThis overrides input(), which isn't caught by the compiler but is unnecessary.
Attachment #8462488 - Flags: review?(jdemooij)
Attachment #8462486 - Flags: review?(jdemooij) → review+
Attachment #8462488 - Flags: review?(jdemooij) → review+
(Assignee)

Comment 3

3 years ago
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/182850749379
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/43cce527da0e
https://hg.mozilla.org/mozilla-central/rev/182850749379
https://hg.mozilla.org/mozilla-central/rev/43cce527da0e
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.