Closed Bug 1043903 Opened 6 years ago Closed 5 years ago

[Messages][Tests] Add integration tests for the thread panel with a large number of messages

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: azasypkin, Assigned: azasypkin, Mentored)

References

Details

(Whiteboard: [lang=js])

Attachments

(1 file)

*** Follow-up from bug 1042887 ***

We need to add integration tests for the thread panel to verify at least the following cases:

* Long thread is scrollable;
* Messages are loaded by chunks while user scrolls and user is able to see all messages.
And send button + input composer are visible in long threads :)
Should be easy to do with example in patch for bug 1053964
Mentor: azasypkin
Whiteboard: [lang=js]
I'd like to work on this. Please assign this to me. and tell me where to start.
(In reply to hharchani from comment #3)
> I'd like to work on this. Please assign this to me. and tell me where to
> start.

Glad to hear that! To simplify this task you'll need to wait for bug 1053964 to be landed (that should happen very soon). But in the meantime, if you're new to Firefox OS development, I'd suggest you to go through [1] and [2] to get grasp of Gaia development and automated testing.

If you have questions you can always get help here or on IRC (#gaia channel [3]).

Thanks!

[1] https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia
[2] https://developer.mozilla.org/en-US/Firefox_OS/Platform/Automated_testing/Gaia_integration_tests
[3] https://wiki.mozilla.org/IRC
Dependency bug 1053964 is landed, so you're welcomed to start working on this one!

If you're still interested I'll assign it to you.

Please, don't hesitate to ask any questions you have here :)

Thanks!
Flags: needinfo?(hharchani)
(In reply to Oleg Zasypkin [:azasypkin] from comment #5)
> Dependency bug 1053964 is landed, so you're welcomed to start working on
> this one!
> 
> If you're still interested I'll assign it to you.
> 
> Please, don't hesitate to ask any questions you have here :)
> 
> Thanks!

Yeah please assign me this bug. I'll start working on it soon.
Thanks.
Flags: needinfo?(hharchani)
Great, thanks!
Assignee: nobody → hharchani
Assignee: hharchani → nobody
Sorry, I could not work on this. I've unassigned myself
Comment on attachment 8569112 [details] [review]
[gaia] azasypkin:bug-1043903-integration-test-scroll > mozilla-b2g:master

Hey Julien,

May I have your early feedback on the approach I use to generate various test data (commented on GitHub)?

Thanks!
Attachment #8569112 - Flags: feedback?(felash)
Assignee: nobody → azasypkin
Status: NEW → ASSIGNED
Comment on attachment 8569112 [details] [review]
[gaia] azasypkin:bug-1043903-integration-test-scroll > mozilla-b2g:master

I left some comments on github.

Good work !
Attachment #8569112 - Flags: feedback?(felash) → feedback+
Comment on attachment 8569112 [details] [review]
[gaia] azasypkin:bug-1043903-integration-test-scroll > mozilla-b2g:master

Hey Julien,

Thanks for the feedback! Fixed nits and added suggestions, so PR should be ready for review.

Thanks!
Attachment #8569112 - Flags: review?(felash)
Comment on attachment 8569112 [details] [review]
[gaia] azasypkin:bug-1043903-integration-test-scroll > mozilla-b2g:master

Some more comments.

Especially I don't think waiveXrays is correctly used here.
Attachment #8569112 - Flags: review?(felash)
Comment on attachment 8569112 [details] [review]
[gaia] azasypkin:bug-1043903-integration-test-scroll > mozilla-b2g:master

(In reply to Julien Wajsberg [:julienw] from comment #13)
> Comment on attachment 8569112 [details] [review]
> [gaia] azasypkin:bug-1043903-integration-test-scroll > mozilla-b2g:master
> 
> Some more comments.

Made comments clearer + some nits; Thanks for review!

> Especially I don't think waiveXrays is correctly used here.

Unfortunately we still need it, see Gecko bug 1155700 I filed for that.
Attachment #8569112 - Flags: review?(felash)
Comment on attachment 8569112 [details] [review]
[gaia] azasypkin:bug-1043903-integration-test-scroll > mozilla-b2g:master

r=me with some nits

thanks for this work !
Attachment #8569112 - Flags: review?(felash) → review+
Thanks for review!
Keywords: checkin-needed
http://docs.taskcluster.net/tools/task-graph-inspector/#ZQQIDltMR4Gattb5h-WgRg

The pull request failed to pass integration tests. It could not be landed, please try again.
Let's try again, but will land manually if autolander isn't able to do this. The latest Treeherder run is completely green.
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Oleg, is there a reason this code is defining TestStorages as explicitly non-configurable?
Flags: needinfo?(azasypkin)
Mmm, I think there is no any particular reason behind that, I see it should be "false" by default anyway :) 

Just curious what is the issue with explicit declaration?
Flags: needinfo?(azasypkin)
> Just curious what is the issue with explicit declaration?

See bug 1107443 and the review request in bug 1179088.  ;)
You need to log in before you can comment on or make changes to this bug.