1043903 - [Messages][Tests] Add integration tests for the thread panel with a large number of messages

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Oleg Zasypkin [:azasypkin]]

*** Follow-up from bug 1042887 ***

We need to add integration tests for the thread panel to verify at least the following cases:

* Long thread is scrollable;
* Messages are loaded by chunks while user scrolls and user is able to see all messages.

Comment 1

[Julien Wajsberg [:julienw]]

And send button + input composer are visible in long threads :)

Comment 2

[Oleg Zasypkin [:azasypkin]]

Should be easy to do with example in patch for bug 1053964

Comment 3

[hharchani]

I'd like to work on this. Please assign this to me. and tell me where to start.

Comment 4

[Oleg Zasypkin [:azasypkin]]

(In reply to hharchani from comment #3)
> I'd like to work on this. Please assign this to me. and tell me where to
> start.

Glad to hear that! To simplify this task you'll need to wait for bug 1053964 to be landed (that should happen very soon). But in the meantime, if you're new to Firefox OS development, I'd suggest you to go through [1] and [2] to get grasp of Gaia development and automated testing.

If you have questions you can always get help here or on IRC (#gaia channel [3]).

Thanks!

[1] https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia
[2] https://developer.mozilla.org/en-US/Firefox_OS/Platform/Automated_testing/Gaia_integration_tests
[3] https://wiki.mozilla.org/IRC

Comment 5

[Oleg Zasypkin [:azasypkin]]

Dependency bug 1053964 is landed, so you're welcomed to start working on this one!

If you're still interested I'll assign it to you.

Please, don't hesitate to ask any questions you have here :)

Thanks!

Comment 6

[hharchani]

(In reply to Oleg Zasypkin [:azasypkin] from comment #5)
> Dependency bug 1053964 is landed, so you're welcomed to start working on
> this one!
> 
> If you're still interested I'll assign it to you.
> 
> Please, don't hesitate to ask any questions you have here :)
> 
> Thanks!

Yeah please assign me this bug. I'll start working on it soon.
Thanks.

Comment 7

[Oleg Zasypkin [:azasypkin]]

Great, thanks!

Comment 8

[hharchani]

Sorry, I could not work on this. I've unassigned myself

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia] azasypkin:bug-1043903-integration-test-scroll > mozilla-b2g:master

Comment 10

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8569112 [details] [review]
[gaia] azasypkin:bug-1043903-integration-test-scroll > mozilla-b2g:master

Hey Julien,

May I have your early feedback on the approach I use to generate various test data (commented on GitHub)?

Thanks!

Comment 11

[Julien Wajsberg [:julienw]]

Comment on attachment 8569112 [details] [review]
[gaia] azasypkin:bug-1043903-integration-test-scroll > mozilla-b2g:master

I left some comments on github.

Good work !

Comment 12

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8569112 [details] [review]
[gaia] azasypkin:bug-1043903-integration-test-scroll > mozilla-b2g:master

Hey Julien,

Thanks for the feedback! Fixed nits and added suggestions, so PR should be ready for review.

Thanks!

Comment 13

[Julien Wajsberg [:julienw]]

Comment on attachment 8569112 [details] [review]
[gaia] azasypkin:bug-1043903-integration-test-scroll > mozilla-b2g:master

Some more comments.

Especially I don't think waiveXrays is correctly used here.

Comment 14

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8569112 [details] [review]
[gaia] azasypkin:bug-1043903-integration-test-scroll > mozilla-b2g:master

(In reply to Julien Wajsberg [:julienw] from comment #13)
> Comment on attachment 8569112 [details] [review]
> [gaia] azasypkin:bug-1043903-integration-test-scroll > mozilla-b2g:master
> 
> Some more comments.

Made comments clearer + some nits; Thanks for review!

> Especially I don't think waiveXrays is correctly used here.

Unfortunately we still need it, see Gecko bug 1155700 I filed for that.

Comment 15

[Julien Wajsberg [:julienw]]

Comment on attachment 8569112 [details] [review]
[gaia] azasypkin:bug-1043903-integration-test-scroll > mozilla-b2g:master

r=me with some nits

thanks for this work !

Comment 16

[Oleg Zasypkin [:azasypkin]]

Thanks for review!

Comment 17

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#ZQQIDltMR4Gattb5h-WgRg

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 18

[Oleg Zasypkin [:azasypkin]]

Let's try again, but will land manually if autolander isn't able to do this. The latest Treeherder run is completely green.

Comment 19

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/a8e4f95dce9db727dda5d408b038f97fb4296557

Comment 20

[Boris Zbarsky [:bzbarsky]]

Oleg, is there a reason this code is defining TestStorages as explicitly non-configurable?

Comment 21

[Oleg Zasypkin [:azasypkin]]

Mmm, I think there is no any particular reason behind that, I see it should be "false" by default anyway :) 

Just curious what is the issue with explicit declaration?

Comment 22

[Boris Zbarsky [:bzbarsky]]

> Just curious what is the issue with explicit declaration?

See bug 1107443 and the review request in bug 1179088.  ;)