Add contacts to the SIM in setUp

RESOLVED FIXED

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: AndreiH, Assigned: RobertC)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We had this problem before in our tests, when contacts were not found on the SIM and we had to ask MV team to manually add some contacts on the SIM the day after.

Can we add contacts to the SIM in setUp for tests like test_import_contacts_from_sim.py ?
If there are no contacts found on the SIM we can add some.

Also Dave mentioned that we should delete http://gaiatest.readthedocs.org/en/latest/testrunner.html#test-data-prerequisites as it would be redundant.
Assignee: nobody → robert.chira
Attachment #8476615 - Flags: review?(zcampbell)
Attachment #8476615 - Flags: review?(viorela.ioia)
Attachment #8476615 - Flags: review?(florin.strugariu)
Attachment #8476615 - Flags: review?(florin.strugariu) → review+
Comment on attachment 8476615 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23147

r+, test works as expected
Attachment #8476615 - Flags: review?(viorela.ioia) → review+
(In reply to Viorela Ioia [:viorela] from comment #2)
> Comment on attachment 8476615 [details] [review]
> Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23147
> 
> r+, test works as expected

Sorry, I had to r-, as I saw an intermittent failure after running the test more times. See details in PR
Attachment #8476615 - Flags: review+ → review-
Attachment #8476615 - Flags: review- → review?(viorela.ioia)
Comment on attachment 8476615 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23147

f+ from me. but I'll leave the final r+ to viorela :)
Attachment #8476615 - Flags: review?(zcampbell) → feedback+
Comment on attachment 8476615 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23147

r+, I'll close the bug after merging the PR
Attachment #8476615 - Flags: review?(viorela.ioia) → review+
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.