1043905 - Add contacts to the SIM in setUp

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[[:AndreiH]]

We had this problem before in our tests, when contacts were not found on the SIM and we had to ask MV team to manually add some contacts on the SIM the day after.

Can we add contacts to the SIM in setUp for tests like test_import_contacts_from_sim.py ?
If there are no contacts found on the SIM we can add some.

Also Dave mentioned that we should delete http://gaiatest.readthedocs.org/en/latest/testrunner.html#test-data-prerequisites as it would be redundant.

Comment 1

[Robert Chira [:RobertC]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23147

Comment 2

[Viorela Ioia [:viorela]]

Comment on attachment 8476615 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23147

r+, test works as expected

Comment 3

[Viorela Ioia [:viorela]]

(In reply to Viorela Ioia [:viorela] from comment #2)
> Comment on attachment 8476615 [details] [review]
> Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23147
> 
> r+, test works as expected

Sorry, I had to r-, as I saw an intermittent failure after running the test more times. See details in PR

Comment 4

[Zac C (:zac)]

Comment on attachment 8476615 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23147

f+ from me. but I'll leave the final r+ to viorela :)

Comment 5

[Viorela Ioia [:viorela]]

Comment on attachment 8476615 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23147

r+, I'll close the bug after merging the PR

Comment 6

[Viorela Ioia [:viorela]]

Merged in: https://github.com/mozilla-b2g/gaia/commit/423a88c7bbcbecd01cbd7197992aed189726651f