Closed Bug 1043928 Opened 6 years ago Closed 5 years ago
[User Story] Manually expand Browser Chrome
As a user I want to manually expand the browser chrome on any window so that I can access browser chrome even if the current site is pinned and/or the current page does not scroll. As a user I want to manually collapse the browser chrome so that I can hide it even if the current site is not pinned and/or the current page does not scroll. Previous interaction spec: https://mozilla.app.box.com/s/4pfp6y8pjhwojtt9yhl8/1/2243605137/19330716869/1
Bug 1039519 tracks expanding & collapsing Rocketbar indirectly by scrolling a browser frame in the new Rocketbar implementation. This bug tracks the new requirement to directly expand/collapse the Rocketbar by tapping and swiping it. * Tapping a collapsed Rocketbar in an app without browser chrome should transition directly to the expanded focused state (this is covered in bug 1043284) * Tapping a collapsed Rocketbar in a browser window or an app window with browser chrome should transition the Rocketbar to an expanded, unfocused state and display any necessary browser chrome. * Swiping up on an expanded, unfocused Rocketbar should collapse it.
Since we have removed the swipe to show/hide the rocketbar I believe this can now be closed. Go scrollgrab!
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
I think it's highly likely that we're going to need a mechanism to do this in the future. Scrollgrab only works for scrollable web pages and not being able to collapse the Rocketbar for non-scrollable apps like Google Maps is quite annoying. It's also not very satisfying that I can't collapse the Rocketbar in the Facebook app without scrolling down the page. We may also find weird cases where it is possible to collapse the Rocketbar but not be able to expand it again. Unblocking the MVP bug because we can do this in a future release, but I would like to keep this bug open.
No longer blocks: 941182
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Not working on this at the moment
Assignee: dale → nobody
Updating for Pin the Web. Francis, as per the Pin the Web prototype I think we can expand the browser chrome with a tap (second tap focuses the URL bar), but do we also need a way to manually collapse it again?
User Story: (updated)
Summary: [User Story] Manually expand/collapse Rocketbar → [User Story] Manually expand/collapse Browser Chrome
We could just collapse it again when you touch the browser frame? (I'd say on scroll, but this will break on pages that aren't scrollable)
Added WIP patch, currently depends on the patch from bug 1168951.
Splitting out manually collapsing browser chrome to a separate bug, bug 1192010 until we have a spec for that.
Summary: [User Story] Manually expand/collapse Browser Chrome → [User Story] Manually expand Browser Chrome
Comment on attachment 8642587 [details] [review] [gaia] benfrancis:1043928 > mozilla-b2g:master Alberto, if you could review this in time for us to get it landed before sprint planning on Monday that would be awesome :D
Attachment #8642587 - Flags: review?(apastor)
Comment on attachment 8642587 [details] [review] [gaia] benfrancis:1043928 > mozilla-b2g:master r=me with a small comment in Github. Thanks!
Attachment #8642587 - Flags: review?(apastor) → review+
Thanks Alberto (weekend code reviews are beyond the call of duty!), I think your comment on the unit test is covered so I've gone ahead and landed this. Please file a follow-up if I was mistaken! https://github.com/mozilla-b2g/gaia/commit/246c8f18a5af4a8333be2f75dd8453a4cb975f7d
Status: REOPENED → RESOLVED
Closed: 6 years ago → 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.