1043942 - UnifiedComplete disables inline autocomplete if urlbar behavior is not the default

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

Typing in "spi" I see Awesomebar results for "spiegel.de" but the URL isn't autocompleted. Turning off UC via its pref makes it work again.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: Screenshot of missing autocomplete

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Attachment: Screenshot with UC pref'ed off

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Can you please add this to the iteration, Marco? Thanks!

Comment 4

[Marco Bonardo [:mak]]

ehr, let's say 5, since we might want a test for whatever this bug is.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Seems to be caused by setting browser.urlbar.default.behavior=1.

Comment 6

[Marco Mucci [:MarcoM]]

Added to Iteration 34.1

Comment 7

[Marco Bonardo [:mak]]

that is basically dut to the fix for bug 810930 I inserted during the rewrite. The current behavior is the expected one because when the default behavior changes we cannot tell where the autoFill entry comes from (history, bookmarks, other?).
So what we do is disable autoFill to avoid ignoring the user's choice about what to suggest.

On the other side this might be surprising to users who got results so far and suddenly don't anymore.
We should at a minimum clarify in the prefs that choosing history/bookmarks disables autoFill. Otherwise we might disable autoFill only when results are restricted to bookmarks.
When they are restricted to history, it's unlikely to be an issue, if it's a bookmark is very likely to be visited, and we also only autoFill typed entries.

So my suggestion would be:
1. still autoFill if results are restricted to history
2. specify in the prefs that choosing Bookmarks will disable autoFill

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Marco Bonardo [:mak] from comment #7)
> So my suggestion would be:
> 1. still autoFill if results are restricted to history
> 2. specify in the prefs that choosing Bookmarks will disable autoFill

That sounds indeed like a fine solution to me.

Comment 9

[Marco Bonardo [:mak]]

Unassigning QA, this will be well covered by automated tests.

Comment 10

[Marco Bonardo [:mak]]

Attachment: patch v1

Comment 11

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8464335 [details] [diff] [review]
patch v1

Review of attachment 8464335 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. The extensive tests should really cover everything afaict.

Comment 12

[Marco Bonardo [:mak]]

Attachment: patch v2

since I'm landing foreign_count at the same time, I'm already fixing bug 1045924 here by making the queries use it.

Comment 13

[Marco Bonardo [:mak]]

https://hg.mozilla.org/integration/fx-team/rev/d0d6a897c568

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d0d6a897c568

Comment 15

[Andrei Vaida [:avaida]]

Setting qe-verify- for this fix since it's already covered by automated testing. Marco, if there's something manual QA can look at here, please flip the flag.