1043967 - With French locale, the sort of the date is broken

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

Attachment: 0001-Use-the-ISO-method-to-display-dates.patch

Dates are displayed using "localdate.toLocaleString" method.

However, from a locale to the other, this is too unpredictable and it is going to break the sort.

For example, the French locale will display
DD/MM/YYYY
and the sort will be done the day instead of the user.

The usage of the ISO 8601 fixes the issue:
2014-07-09T15:01:31.324Z

As an other argument:
http://xkcd.com/1179/
;)

Comment 1

[[e-mail] (:bhearsum)]

I've noticed this too (my locale string is set to Filipino). However, ISO 8601 strings are not terribly readable...I wonder if this can be fixed by fiddling with something in data tables? Ie, maybe there's a hidden attribute that can influence sorting, but doesn't affect the displayed date.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Ben, I agree I have been lazy by picking ISO 8601. ;) I didn't care much since all users of this app are engineer.
 
However, will "2014-07-09 15:01:31" work for you?

Comment 3

[[e-mail] (:bhearsum)]

(In reply to Sylvestre Ledru [:sylvestre] from comment #2)
> Ben, I agree I have been lazy by picking ISO 8601. ;) I didn't care much
> since all users of this app are engineer.
>  
> However, will "2014-07-09 15:01:31" work for you?

Yeah, I guess that's fine.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Attachment: 0001-Use-the-ISO-method-to-display-dates.patch

Piouf, I forgot how date management is a pain in Javascript.
I used Jquery for the date formating.

If we don't care about standard stuff, I could use:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toLocaleFormat

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 8462605 [details] [diff] [review]
0001-Use-the-ISO-method-to-display-dates.patch

Review of attachment 8462605 [details] [diff] [review]:
-----------------------------------------------------------------

I'd rather stick with standards compliant stuff. This looks fine. Rail is away for 2 weeks, so let's not block on him.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8462605 [details] [diff] [review]
0001-Use-the-ISO-method-to-display-dates.patch

Thanks. Merged:
http://git.mozilla.org/?p=build/release-kickoff.git;a=commitdiff;h=329e1db9f1cef4899c882520e62d0923a055863c

Comment 7

[[e-mail] (:bhearsum)]

This changed is trivial enough. I just it to production.