1044083 - Make web-visible XPConnect exceptions SecurityError DOMExceptions

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Bobby Holley (:bholley)]

See bug 965898 comment 25. We need to do this at some point, but it might require various refactorings, so I'm splitting this out of that bug.

Comment 1

[Boris Zbarsky [:bzbarsky]]

So the big problem is that these exceptions are thrown from Proxy.cpp, which has no knowledge of DOMException, right?  If we could just move these into Gecko code, this would be trivial.

Most simply, could we push the throwing down into the actual handler involved, which I assume is in Gecko code?

Comment 2

[Bobby Holley (:bholley)]

I think we should make the error reporting operate with a virtual trap on BaseProxyHandler with a default implementation that does what the Proxy.cpp stuff does now. We can then override that in CrossOriginXrayWrapper to give ourselves proper DOM semantics. We could also optionally override it in FilteringWrapper and XrayWrapper if we wanted that to be exposed to the other (non-Web) cases as well.

Comment 3

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.

Comment 4

[Boris Zbarsky [:bzbarsky]]

We no longer use Xrays for web-facing stuff, and the new cross-origin wrapper machinery from bug 1363208 throws SecurityError DOMExceptions.

Calling this fixed.