1044096 - Duplicates "Signings" Appearing In Admin

Status: VERIFIED FIXED

(Websites Graveyard :: mobilepartners.mozilla.org, defect)

Description

[Ben (:bensternthal)]

Attachment: Screen Shot 2014-07-25 at 10.16.59 AM.png

I am seeing quite a few duplicate prototype agreement signings in the admin. I did not think this would be possible.

Screenshot shows an example.

Comment 1

[Osmose [:osmose, :mkelly]]

There's no unique constraint so it's possible to get these, only case it should show up is people clicking the agree button multiple times.

You should be able to safely delete duplicates for the time being. We could add the unique constraint, we'd just need to make sure to handle the case of a duplicate being rejected, as we don't want the user to see an error if they click agree too fast. 

Is that a good solution?

Comment 2

[Ben (:bensternthal)]

I think enforcing one 'signing' per version is a good idea. Because this is the official record I would prefer this to be as clean as possible.

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/fxoss

https://github.com/mozilla/fxoss/commit/11a707b59b6fcdf25d171f5f81041c2ee9da3cdf
Fix bug 1044096: Make SignedAgreements unique by user/agreement pair.

https://github.com/mozilla/fxoss/commit/bbe5392434629891601aa7b37b59aa3d48a83f13
Merge pull request #167 from Osmose/unique-signed-agreements

Fix bug 1044096: Make SignedAgreements unique by user/agreement pair.