Closed
Bug 1044165
Opened 10 years ago
Closed 10 years ago
fix BuildReaderError exception printing to cope properly with SyntaxError
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla33
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
1.13 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Some moz.build syntax errors cause the thrown SyntaxError object to not include
an offset field, leading to all sorts of hilarity when we try printing messages
depending on SyntaxError.offset. Check for this case and simply don't print
the caret if so.
Attachment #8462746 -
Flags: review?(gps)
Comment 2•10 years ago
|
||
Comment on attachment 8462746 [details] [diff] [review]
fix BuildReaderError exception printing to cope properly with SyntaxError
Review of attachment 8462746 [details] [diff] [review]:
-----------------------------------------------------------------
A test case would be nice. But meh.
Attachment #8462746 -
Flags: review?(gps) → review+
Assignee | ||
Comment 3•10 years ago
|
||
This landed: http://hg.mozilla.org/mozilla-central/rev/3928403b6627
I guess mcMerge missed this.
Assignee: nobody → nfroyd
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•