fix BuildReaderError exception printing to cope properly with SyntaxError

RESOLVED FIXED in mozilla33

Status

defect
RESOLVED FIXED
5 years ago
a year ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla33

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

5 years ago
No description provided.
Assignee

Comment 1

5 years ago
Some moz.build syntax errors cause the thrown SyntaxError object to not include
an offset field, leading to all sorts of hilarity when we try printing messages
depending on SyntaxError.offset.  Check for this case and simply don't print
the caret if so.
Attachment #8462746 - Flags: review?(gps)
Comment on attachment 8462746 [details] [diff] [review]
fix BuildReaderError exception printing to cope properly with SyntaxError

Review of attachment 8462746 [details] [diff] [review]:
-----------------------------------------------------------------

A test case would be nice. But meh.
Attachment #8462746 - Flags: review?(gps) → review+
Assignee

Comment 3

5 years ago
This landed: http://hg.mozilla.org/mozilla-central/rev/3928403b6627

I guess mcMerge missed this.
Assignee: nobody → nfroyd
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33

Updated

a year ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.