1044183 - Remove Jenkins Specific Settings from Config Files

Status: RESOLVED INVALID

(Socorro :: Infra, task)

Description

[Trevor Bramwell :bramwelt]

The files:
* config/alembic.ini-dist
* socorro/unittest/config/jenkins.py.dist

Both contain Jenkins specific configuration. It makes sense that jenkins configuration is in socorro/unittest/config/jenkins.py.dist, but not alembic.ini-dist.

As jenkins.py.dist is a Python configuration file, I believe can be removed because it only exists for historic reasons.

Comment 1

[Robert Helmer [:rhelmer]]

(In reply to Trevor Bramwell :bramwelt from comment #0)
> The files:
> * config/alembic.ini-dist
> * socorro/unittest/config/jenkins.py.dist
> 
> Both contain Jenkins specific configuration. It makes sense that jenkins
> configuration is in socorro/unittest/config/jenkins.py.dist, but not
> alembic.ini-dist.

The only reason it's like this is because alembic doesn't provide a way to override sqlalchemy URL (AFAICT from the docs) - it's mentioned in http://socorro.readthedocs.org/en/latest/installation/postgres.html#add-a-new-superuser-account-to-postgresql but people setting up Socorro miss it all the time.

Not sure what the best way to override it is. ConfigParser can read/write .ini files, so that might be an option - that is, instead of doing "cp alembic.ini-dist alembic.ini" there could be a tool used instead that builds the database URL and sets sqlalchemy.url correctly.

We *could* override in setupdb_app.py (there's an old bixie example in there now), but that might lead to more confusion if it doesn't match what's in alembic's config file (running alembic directly is a totally reasonable thing to do after all)

Comment 2

[JP Schneider [:jp]]

Whole new world