Closed
Bug 1044204
Opened 10 years ago
Closed 10 years ago
Upcoming Events fails to load after viewing my events page
Categories
(Webmaker Graveyard :: Events, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cade, Assigned: cade)
Details
(Whiteboard: [aug8])
Attachments
(1 file)
STR: 1. Go to events.webmaker.org 2. Click on your username to show the drop down, and select "My Events" 3. click Upcoming Events Expected: Events should load Actual: nothing loads, error in console: TypeError: Cannot read property 'protocol' of undefined at Gb (http://localhost:1981/bower_components/angular/angular.min.js:120:55) at p (http://localhost:1981/bower_components/angular/angular.min.js:69:264) at requestRange (http://localhost:1981/bower_components/angular-paginate-anything/src/paginate-anything.js:111:13) at h.$scope.gotoPage (http://localhost:1981/bower_components/angular-paginate-anything/src/paginate-anything.js:82:13) at new controller (http://localhost:1981/bower_components/angular-paginate-anything/src/paginate-anything.js:151:18) at d (http://localhost:1981/bower_components/angular/angular.min.js:33:335) at Object.instantiate (http://localhost:1981/bower_components/angular/angular.min.js:33:464) at http://localhost:1981/bower_components/angular/angular.min.js:65:486 at http://localhost:1981/bower_components/angular/angular.min.js:52:156 at r (http://localhost:1981/bower_components/angular/angular.min.js:7:386) angular.js:9563 (anonymous function)
Assignee | ||
Updated•10 years ago
|
Keywords: ateam-automation-task
Assignee | ||
Updated•10 years ago
|
Whiteboard: [aug8]
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•10 years ago
|
||
I've narrowed this down to line 113 of paginate-anything.js, which hadles the events pagination. when we hit the request function for events, $scope.url is undefined for some reason.
Assignee | ||
Comment 3•10 years ago
|
||
There seems to be a race condition (albeit, a very easy to hit race condition) where the pagination directive can attempt to fetch events before the we-listing directive can set the serviceURL, so if we default the value, the problem is negated.
Attachment #8464078 -
Flags: review?(gavin)
Updated•10 years ago
|
Attachment #8464078 -
Flags: review?(gavin) → review+
Comment 4•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker-events-2 https://github.com/mozilla/webmaker-events-2/commit/80b88e9104de86ff130b25755948744d233d093e Bug 1044204 - Default the serviceURL value so that pagination doesn't lose it's mind
Assignee | ||
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•