Dark theme scrollbars are too thin

NEW
Unassigned

Status

()

Firefox
Developer Tools
3 years ago
4 months ago

People

(Reporter: canuckistani, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

Created attachment 8462857 [details]
scrollbars-dark.gif

I installed the Yosemite Beta today, and the scrollbars are super thin, reminds me of the complaints from bug 933215. This seems to be only a problem on 10.10, but I can repro on both Aurora 33 and Nightly 34.

Updated

3 years ago
Blocks: 1040250

Comment 1

3 years ago
This also can be verified on Win 7 x64.
Related to bug 1047148.
(In reply to Jeff Griffiths (:canuckistani) from comment #0)
> Created attachment 8462857 [details]
> scrollbars-dark.gif
> 
> I installed the Yosemite Beta today, and the scrollbars are super thin,
> reminds me of the complaints from bug 933215. This seems to be only a
> problem on 10.10, but I can repro on both Aurora 33 and Nightly 34.

Per comment #1, is this really a 10.10 issue rather than just an issue with the dark theme?
Flags: needinfo?(jgriffiths)
(In reply to :Gijs Kruitbosch from comment #2)
> Per comment #1, is this really a 10.10 issue rather than just an issue with
> the dark theme?

You're right - it's just an issue with the dark theme generally.
Flags: needinfo?(jgriffiths)
No longer blocks: 1040250
Summary: Dark theme scrollbars are too thin on 10.10 → Dark theme scrollbars are too thin

Comment 4

3 years ago
Why doesn't this block bug 1040250 anymore?
(In reply to José Jeria from comment #4)
> Why doesn't this block bug 1040250 anymore?

Because as noted in comment #2 and comment #1, it isn't an OS X 10.10 issue?
Duplicate of this bug: 1064248
Created attachment 8488710 [details] [diff] [review]
scrollbars-styling-WIP.patch

I think one issue is that the scrollbar styles are not reliably being applied for HTML documents (like markup view, codemirror, etc).  Here is a patch that

a) refactors the loading of floating-scrollbars to use @media queries in CSS instead of checking once in JS, which seems better because it detects OS preference level changes automatically.  So in OSX if you change scrollbar behavior it will pick up the changes
b) increases the width of the scrollbars a bit.  Unforuntely this doesn't apply to HTML docs on OSX - see (c).
c) Adds some colors for debugging on OSX.  What's weird is that the styles are definitely being applied to HTML documents (see the colors, for instance) but setting width, min-width, and max-width have no effect once it hits a certain size.  In the patch they are set to be very small - 5px - but they end up around 20px wide.  If I set them to be 100px the size increases. I've tried a variety of things, like hiding all of the children under the scrollbar, and the width is still there.

Regarding (c), I have no idea what is going on.  Paul, you've done some styling with this before - any ideas how to get the width / height of the floating scrollbars to work in HTML documents?
Flags: needinfo?(paul)
Created attachment 8488711 [details]
weird-sizing-with-patch-applied.png

Here is a screenshot annotating the issues I was talking about with XUL vs HTML documents and scrollbar styling

Comment 9

3 years ago
(In reply to Brian Grinstead [:bgrins] from comment #7)
> Regarding (c), I have no idea what is going on.  Paul, you've done some
> styling with this before - any ideas how to get the width / height of the
> floating scrollbars to work in HTML documents?

No, not really, sorry.
Flags: needinfo?(paul)
Duplicate of this bug: 1219114

Comment 11

4 months ago
In addition to being too thin, the floating scroll bars in the dev tools don't reach all the way to the right edge of the window. This means when I move my mouse pointer all the way to the right edge of my screen I can't grab the scroll bar. I have to hit the right edge, then adjust left a few pixels hoping I don't overshoot the thin scroll bars. It takes me several attempts to grab the scroll bar every single time, for years.
You need to log in before you can comment on or make changes to this bug.