1044265 - [B2G][Contacts] When adding a phone number the subtext letters on the keypad dissapear when long pressed

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Josh Schmitt [Joshs]]

Description:
Keypad long presses causes the letters on the keypad to disappear for the selected key.

Repro Steps:
1) Update a Flame to 20140725040205
2) Open Contacts app
3) Select the '+' icon
4) Select 'Mobile'
5) Long press on a number

Actual:
The letters dissapear duing long press

Expected:
The letters do not disappear 

Environmental Variables:
Device: Flame Master
Build ID: 20140725040205
Gaia: 3a06aa58245eaf848242d6d1497c1af536fffabd
Gecko: 6c0971104909
Version: 34.0a1 (Master)
Firmware Version: v122

User Agent: (Obtain this by going to www.whatsmyuseragent.com on the device browser)

Notes:
Repro frequency: 100%
Link to failed test case:
See attached: https://www.youtube.com/watch?v=hGQuFSZn58k&feature=youtu.be and logcat

Comment 1

[Josh Schmitt [Joshs]]

User agent for 2.1 flame:

User agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

I cannot reproduce the behaviour since I do have the letters already appearing in the keyboard in 2.0.

In the case this still persist,  the  bug won't affect just to contact, but any other app using the numeric keyboard.

Tim is this a known issue, or any change that we needed to add to contacts?

Thanks!

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Sounds like incomplete feature from bug 1014454.

[Blocking Requested - why for this release]: Incomplete feature.

George, could you confirm my assessment here? Please undo my changes if that turned out to be wrong.

Comment 4

[Peter Bylenga [:PBylenga]]

QAWanted for Branch checks.

Comment 5

[Joshua Mitchell (Inactive)]

Issue repros in 2.1 Flame and 2.0 Buri

Device: Flame Master
Build ID: 20140728065013
Gaia: 295967a0b824a355ae9d57fb08f3632ed2ad18dd
Gecko: d77f6a96ff96
Version: 34.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Buri Master
Build ID: 20140728065013
Gaia: 295967a0b824a355ae9d57fb08f3632ed2ad18dd
Gecko: d77f6a96ff96
Version: 34.0a1 (Master)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

----------------------------------------------------------------------------------------

Feature (subtext on the keypad buttons) is not implemented in 2.0 or 1.4

Device: Flame 2.0
Build ID: 20140728065913
Gaia: b56f023ff247312a344e8f233898e803459788b9
Gecko: e11d0b232ced
Version: 32.0 (2.0)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Device: Flame 1.4
Build ID: 20140728085914
Gaia: eb3b185325901d4c04e2d43eb58d90835213bea9
Gecko: 8c8883bb5797
Version: 30.0 (1.4)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Comment 6

[Peter Bylenga [:PBylenga]]

I think you mistyped it reproduced in 2.0 buri.  Your environment says Buri: Master.  Requesting a window to see if we can confirm Comment 3.

Comment 7

[Joshua Mitchell (Inactive)]

Yes, it should have said it repros in 2.1 Buri and not 2.0

Comment 8

[Joshua Mitchell (Inactive)]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #3)
> Sounds like incomplete feature from bug 1014454.
> 
> [Blocking Requested - why for this release]: Incomplete feature.
> 
> George, could you confirm my assessment here? Please undo my changes if that
> turned out to be wrong.

Seems like you are right Tim. That bug is in this push-log and is the most probable cause.

Initial Regression Window:

Last Working:
Device: Flame Master
Build ID: 20140707141226
Gaia: 99f56d9db3cd37c684b01de6fed786421f47e2b7
Gecko: f14b47c39013
Version: 33.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:33.0)

First Broken:
Device: Flame Master
Build ID: 20140707144129
Gaia: 1dc9e53393ae4680a174dffa44a958ec564ebbe8
Gecko: dfef245594b6
Version: 33.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0


Last Working Gaia First Broken Gecko: Issue does NOT reproduce
Gaia: 99f56d9db3cd37c684b01de6fed786421f47e2b7
Gecko: dfef245594b6

First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia: 1dc9e53393ae4680a174dffa44a958ec564ebbe8
Gecko: f14b47c39013

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/99f56d9db3cd37c684b01de6fed786421f47e2b7...1dc9e53393ae4680a174dffa44a958ec564ebbe8

broken by (or incomplete) bug 1014454  - George already has a NI

Comment 9

[(Inactive after June) George Duan [:gduan] [:喬智]]

Hi Carol,
do we need to change the color of letters when long-pressing?

Comment 10

[Carol Huang [:Carol]]

Hi George,
The color of the sub-text wont change color when it's long-pressed. Thank you!

Comment 11

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Hi Rudy,
could you help to review this fix?
Thanks.

Comment 12

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8463793 [details] [review]
PR to master

For got to set review flag to Rudy.

Hi Rudy,
could you review my patch?
Thanks.

Comment 13

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8463793 [details] [review]
PR to master

Looks good to me.
Thanks.

Comment 14

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks,
merge to master
https://github.com/mozilla-b2g/gaia/commit/9a9ef7a3064c8ea6adefe0a592b292f4e0e54a67

Comment 15

[pete siphantong [:Petes]]

This bug is verified fixed on the Flame 2.1 (319mb) and the Flame 2.2 (319mb)


Flame 2.2 Master KK (319mb) (Full Flash)

Device: Flame 2.2
BuildID: 20141010040202
Gaia: 1036b544b7e102592bd9fab95cd9317329ac1293
Gecko: 50b689feab5f
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Flame 2.1 KK (319mb) (Full Flash)

Environmental Variables:
Device: Flame 2.1
BuildID: 20141010000201
Gaia: bc8eb493311c58f1f311a56b8b645b52bfbd2f71
Gecko: 72c13d8631ff
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Result: The letters do not disappear when long pressing.