1044274 - [Gallery][RTL] gallery image view back button is not RTL

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: 2014-07-25-15-15-27.png

1. set the device language to arabic
2. reboot the device
3. launch gallery
4. select an image

Expected: back arrow is RTL
Actual: back arrow is still LTR

Gaia      3a06aa58245eaf848242d6d1497c1af536fffabd
Gecko     https://hg.mozilla.org/mozilla-central/rev/6c0971104909
BuildID   20140725040205
Version   34.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230
flame

Comment 1

[Stephany Wilkes]

Assigning to Pavel. Pavel, let me know if you need any UX guidance here. You should be able to view the correct/expected user experience elsewhere in the OS, but if not just ni? me. Thank you!

Comment 2

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

I will take this :)

Comment 3

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Comment 4

[Ahmed Nefzaoui [:Nefzaoui]]

Comment on attachment 8470682 [details] [review]
patch for Gaia/master

I left some comments, one of them is critical for performance AFAIK, which is using PNG files instead of hacking on CSS :)
Let's get that changed first :)
Thanks!

Comment 5

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks :)
Done :)

Comment 6

[Ahmed Nefzaoui [:Nefzaoui]]

Good to go.
TBH I like to have everything-RTL at the end of the file just like everywhere else.
But that's up to you, in any case it seems fine. :)

Comment 7

[Punam Dahiya [:pdahiya]]

Comment on attachment 8470682 [details] [review]
patch for Gaia/master

Thanks for the patch, it looks good and has my r+.

Comment 8

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/bf52411cfa23a052df8b7b4845432282ae390eda

Comment 9

[Peter Bylenga [:PBylenga]]

Mass Edit: adding the [rtl-meta]

Comment 10

[Elie]

This issue exist on Flame 2.2:
Gaia-Rev        7c5b27cad370db377b18a742d3f3fdb0070e899f
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/748b20315f75
Build-ID        20150114002502
Version         37.0a2
Reproduce rate  5/5

Comment 11

[Elie]

Attachment: 2015-01-15-16-29-41.png

This issue exists on Flame2.2,refer to picture:2015-01-15-16-29-41.png

Comment 12

[Josh Cheng [:josh]]

Hi Pavel, 
It seems the problem still exist at latest 2.2 build per comment 11. Could you please check again?
Thanks!

Comment 13

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Sure,

I will take a look tomorrow. But I think that the screenshot from Comment 11 is not in RTL mode (see the toolbar at the bottom)

Comment 14

[Delphine Lebédel [:delphine - Use needinfo]]

Ok so just talked offline with Ahmed. He confirms that according to UX specs, back button should not be mirrored here. Also, the toolbar at the bottom shouldn't be mirrored either. I'm going to attach a screenshot, but according to what I see on latest 2.2, there is therefore no RTL issue.
What confuses me is that this bug was not closed as Resolved-Invalid when it was opened, if this is in fact the correct RTL behavior. 
Needinfo on UX so they can confirm from my screenshot that everything is in fact RTL-compliant, before I close this bug as Resolved Invalid. Thanks!

Comment 15

[Delphine Lebédel [:delphine - Use needinfo]]

Attachment: Latest 2.2 RTL screenshot

Comment 16

[Stephany Wilkes]

Delphine, you are correct in comment #14: this should have been resolved invalid because the correct RTL behavior was already present. I'll do that now.

Comment 17

[Coler]

According to Comment 14 and Comment 16, clear "verifyme" in keywords.