1044290 - Change name of "Firefox Marketplace" in OpenSearch dropdown

Status: VERIFIED FIXED

(Marketplace Graveyard :: General, defect, P4)

Description

[Elizabeth Hunt[:ezoehunt]]

Attachment: Screen Shot 2014-07-25 at 3.50.20 PM.png

Browser search dropdown on marketplace.firefox.com currently says:
[addons icon] Add Firefox Marketplace
See attached screenshot. Note that wrong icon is used here.

Change to:
[marketplace icon] Add Firefox Apps

Once it's added to the user's search dropdown, it should say:
[marketplace icon] Firefox Apps

This new wording aligns with the work being done on the about:apps page to be integrated into the browser.

Comment 1

[Wil Clouser [:clouserw]]

https://github.com/mozilla/zamboni/pull/2355

Comment 2

[Christopher Van Wiemeersch [:cvan]]

Why is the favicon in your screenshot of a puzzle icon too? Both icons specified in https://marketplace.firefox.com/opensearch.xml are of the Marketplace basket icon.

Comment 3

[Elizabeth Hunt[:ezoehunt]]

The request is to change the puzzle icon to the marketplace icon. And to change the language to "Add Firefox Apps".

Comment 4

[Wil Clouser [:clouserw]]

I changed the name in https://github.com/mozilla/zamboni/compare/62f2e051eb9f...b908c2dbb1c7 .  Apparently opensearch wants a 16x16 icon, heh.  Philip - do you have one that small available that you could attach?

Also interesting, is that marketplace.firefox.com/favicon.ico is the puzzle piece.

Comment 5

[Christopher Van Wiemeersch [:cvan]]

Wil, there is a 16x16 icon: https://github.com/mozilla/zamboni/blob/b908c2dbb1c7d49d565d831db6c6674d4ec5b7fd/mkt/templates/mkt/opensearch.xml#L6

That data URI looks like this: http://cl.ly/image/0c1t1A1I252g/x-icon.ico

Comment 6

[Wil Clouser [:clouserw]]

(In reply to Christopher Van Wiemeersch [:cvan] from comment #5)
> Wil, there is a 16x16 icon:
> https://github.com/mozilla/zamboni/blob/
> b908c2dbb1c7d49d565d831db6c6674d4ec5b7fd/mkt/templates/mkt/opensearch.xml#L6
> 
> That data URI looks like this: http://cl.ly/image/0c1t1A1I252g/x-icon.ico

Oh.  Then I don't know why it's not working.

Comment 7

[Mathieu Pillard [:mat]]

FWIW the current version we have in production works fine for me, I can see a marketplace icon after I've added it.

Comment 8

[Mathieu Pillard [:mat]]

Taking, because we need to solve the icon issue.

From what I can gather by testing, Firefox uses the site favicon when displaying the search engine menu - this is because at this point, it hasn't loaded the opensearch.xml file yet, it's using the title from the <link> element. Since our favicon.ico file is indeed the puzzle icon, that's what you see when adding the search engine.

It's weird that you are also seeing the puzzle icon *after* you've added it. It could be a bug, it could be some caching going on, I'm not sure. To be on the safe side, I'll change our opensearch.xml file to use an absolute URI to the icon instead of a data: URI, since that's what appears to be used by most websites out there.


TL;DR: I'm going to make a pull request to:
- Change our favicon.ico file
- Change our opensearch.xml to use an https:// URI to the 16x16 icon instead of a data: URI.

Comment 9

[Wil Clouser [:clouserw]]

Changing the favicon.ico is good.  No need to change the 16x16 icon.  No one here is seeing the puzzle piece after installing as far as I know.

Comment 10

[Mathieu Pillard [:mat]]

Favicon changed in https://github.com/mozilla/zamboni/commit/c26fd915df73657fb7ed2275f878bf8990522007

Comment 11

[Iulian Timis]

Verified as fixed.
Attaching postfix screenshot.
Closing bug

Comment 12

[Iulian Timis]

Attachment: postfix_firefox_apps.png

Comment 13

[Philip [:pwalm]]

That looks awesome, nice one!